fix(frontend): mock useMessages in WorkflowBuilder unit test#33
Open
LukasHirt wants to merge 1 commit into
Open
fix(frontend): mock useMessages in WorkflowBuilder unit test#33LukasHirt wants to merge 1 commit into
LukasHirt wants to merge 1 commit into
Conversation
WorkflowBuilder.vue calls useAutomationConnect(), which calls useMessages() from @ownclouders/web-pkg at setup time. The test's mock of that module didn't include useMessages, so mounting the component threw and failed CI. Signed-off-by: Lukas Hirt <info@hirt.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorkflowBuilder.vuecallsuseAutomationConnect(), which callsuseMessages()from@ownclouders/web-pkgat setup time.tests/unit/WorkflowBuilder.spec.tsmocks@ownclouders/web-pkgbut didn't includeuseMessages, so mounting the component threw and failed thefrontendCI job.mainand is inherited by every open PR rebased on top of it.Test plan
pnpm test:unit runpasses locally (6 files, 14 tests)