[1/n] [dropshot-api-manager] redesign compatibility issue output#102
Closed
sunshowers wants to merge 1 commit into
Closed
Conversation
Created using spr 1.3.6-beta.1
Collaborator
Author
|
Closing in favor of #95 (silly spr). |
sunshowers
deleted the
sunshowers/spr/1n-dropshot-api-manager-redesign-compatibility-issue-output-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the improvements in drift 0.2, redesign the way we display compatibility issues to show all the endpoints from which a component is accessible.
This is a pretty major rework of the compatibility detection and display code, though I hope it's relatively straightforward.
The output looks quite nice! Here's an example: (screenshot here)
More improvements to this will come in subsequent PRs (split them up to make it easier to review)