Skip to content

Bump dependencies#2521

Open
mkeeter wants to merge 2 commits into
masterfrom
mkeeter/bump-deps
Open

Bump dependencies#2521
mkeeter wants to merge 2 commits into
masterfrom
mkeeter/bump-deps

Conversation

@mkeeter
Copy link
Copy Markdown
Collaborator

@mkeeter mkeeter commented May 19, 2026

I ran into a similar issue as #2480, becausetlvc and tlvc-text specified versions which are no longer at the tip of the repo. After bumping them, a bunch of other stuff broke, so I bumped it as well!

The only logic change is that we're now building the initial Hubris archive with bzip2 compression (instead of deflate). This doesn't change the end result, because hubpack was modifying our archives (e.g. adding a caboose) and already used bzip2 compression when writing them back. It does let us remove a few dependencies by removing the deflate feature from zip.

@mkeeter mkeeter requested review from cbiffle, flihp and labbott as code owners May 19, 2026 19:36
@mkeeter mkeeter force-pushed the mkeeter/bump-deps branch from 5d5473c to 7d97b1d Compare May 19, 2026 20:30
@hawkw
Copy link
Copy Markdown
Member

hawkw commented May 19, 2026

This doesn't change the end result, because hubpack was modifying our archives (e.g. adding a caboose) and already used bzip2 compression when writing them back

hub_pack_, or hub_tools_? I think you meant hubtools...

@mkeeter
Copy link
Copy Markdown
Collaborator Author

mkeeter commented May 19, 2026

I did mean hubtools! hubpack is blameless (because it's distributed through crates.io)

@jamesmunns
Copy link
Copy Markdown
Contributor

CC @labbott - this PR requires a RoT group signoff because it touches /lib/dice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants