Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal inheritance implementation, which is just enough to fix our one problem child. The problem child is, of course,
cpu-seq.idol– which has different operations on Cosmo versus Gimlet.The challenge here is that both client and server still need to agree on operations. The implementation is deliberately limited to make it hard to screw up. It allows exactly one layer of inheritance: an
idolfile may declare abasemember, which must define aBaseInterface(..)object. You can't use theBaseInterfaceas an Idol interface, removing one possible failure mode. In our motivating example, you must explicitly select eithercpu-seq.cosmo.idolorcpu-seq.gimlet.idol(e.g. with feature flags).We serialize the merged file into the
.idolatrysection of the generated code, so Humility sees all the operations (in the correct order).