bgp, rdb: make small-domain proptests exhaustive#691
Open
Conversation
The PathOrigin dedup test draws from a 3x3 space — replace with an exhaustive loop. The cross-family within test depends only on the V4/V6 discriminant — replace with a single deterministic case. Delete the prefix-length-in-bounds tests, which only assert that proptest's own range constraint holds.
taspelund
force-pushed
the
trey/proptest_cleanup
branch
from
a9477b0 to
ae64f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PathOrigin dedup test draws from a 3x3 space — replace with an exhaustive loop. The cross-family within test depends only on the V4/V6 discriminant — replace with a single deterministic case. Delete the prefix-length-in-bounds tests, which only assert that proptest's own range constraint holds.