[fm] factor out fmt_json_value into its own module#10511
Merged
Conversation
`nexus_types::fm` has a little utility for formatting `serde_json::Value`s as bulleted lists. Currently, this is only used for formatting sitrep analysis reports. #10460 factored it out of the `analysis_reports` module to use it for formatting case facts. While working on #10505, I realized it would also be useful to have this for use in `omdb` commands for reconstructing analysis reports from CRDB. Since #10460 isn't going to merge until after R20, I figured it would be helpful to just pull out the change to factor this out into its own commit that both our branches could depend on.
smklein
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nexus_types::fmhas a little utility for formattingserde_json::Values as bulleted lists. Currently, this is only used for formatting sitrep analysis reports. #10460 factored it out of theanalysis_reportsmodule to use it for formatting case facts. While working on #10505, I realized it would also be useful to have this for use inomdbcommands for reconstructing analysis reports from CRDB. Since #10460 isn't going to merge until after R20, I figured it would be helpful to just pull out the change to factor this out into its own commit that both our branches could depend on.