Fixes #21: merge test coverage with e2e tests in CI#22
Open
Reactivity512 wants to merge 1 commit into
Open
Conversation
metafates
requested changes
Jun 21, 2026
metafates
left a comment
metafates
left a comment
Member
There was a problem hiding this comment.
Thank you! Left some review comments
| if: runner.os != 'Windows' | ||
| run: | | ||
| go test -race -v -coverprofile=coverage.out -coverpkg=./... ./... | ||
| make coverage-ci TEST_FLAGS="-race -v" |
Member
There was a problem hiding this comment.
Let's inline this so that workflow won't depend on Makefile
| go tool cover -func coverage.out | ||
|
|
||
| # get test coverage-ci | ||
| .PHONY: coverage-ci |
Member
There was a problem hiding this comment.
.PHONY isn't needed here because we have MAKEFLAGS += --always-make
| coverage-ci: | ||
| go test $(TEST_FLAGS) -coverprofile=coverage.unit.out -coverpkg=./... ./... | ||
| go test $(TEST_FLAGS) -tags e2e -coverprofile=coverage.e2e.out -coverpkg=./... ./... || true | ||
| go run github.com/dlespiau/covertool@latest merge -o coverage.out coverage.unit.out coverage.e2e.out |
Member
There was a problem hiding this comment.
If possible, I think we should avoid relying on third-party tools.
I think we can simplify this a bit.
Overall, it should look like this:
go test ./...- run unit testsgo test -tags e2e -count 1 ./examples_test.go- run e2e testsgo test -tags example -coverprofile coverage.out -coverpkg ./... ./... || true- run both unit tests and examples (which are invoked from e2e).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21: merge test coverage with e2e tests in CI