Show Authors#65
Merged
Merged
Conversation
jsparber
force-pushed
the
jsparber/add_connection_popover
branch
4 times, most recently
from
1d09a44 to
c07529c
Compare
Collaborator
Author
|
this is based on #67 |
jsparber
force-pushed
the
jsparber/add_connection_popover
branch
3 times, most recently
from
a1c6acc to
392ee8c
Compare
adzialocha
approved these changes
Apr 24, 2025
Member
adzialocha
left a comment
adzialocha
left a comment
There was a problem hiding this comment.
Very cool feature!
I think the actual tracking of online state is not correct, but we can handle that in a sub-sequent PR.
jsparber
force-pushed
the
jsparber/use_trait
branch
2 times, most recently
from
daecc46 to
23b2391
Compare
This introduces a SystemSettings object that exposes ClockFormat and monospace font.
Call methods on the subscribed document when authors are added to a document or when they change online/offline.
This is the start of the ConnectionPopover discussed in #51
jsparber
force-pushed
the
jsparber/add_connection_popover
branch
from
392ee8c to
2934e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs still quite some work but it creates the basic api that
aardvark-docwill expose to the app layer.