Skip to content

Fix binary path expansion#17

Merged
pablopunk merged 1 commit into
pablopunk:mainfrom
liborw:fix/binary-expand
May 18, 2026
Merged

Fix binary path expansion#17
pablopunk merged 1 commit into
pablopunk:mainfrom
liborw:fix/binary-expand

Conversation

@liborw

@liborw liborw commented May 15, 2026

Copy link
Copy Markdown
Contributor

This fixes binary path expansion in pi.nvim.

README.md suggested this should already work, but cfg.binary paths like ~/bin/pi were not expanded. This change expands both string and table forms so configured binaries resolve correctly.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed handling of shell and path placeholders in multi-part binary configurations. Placeholders in list-based configurations are now properly expanded, matching the behavior of string-based configurations.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b3d695a-39d6-4c08-a520-2112b96d56b5

📥 Commits

Reviewing files that changed from the base of the PR and between 8d13ed4 and b062fbf.

📒 Files selected for processing (1)
  • lua/pi/init.lua

Walkthrough

M.get_cmd() in lua/pi/init.lua now applies vim.fn.expand() to each element when cfg.binary is provided as a table. Previously, only the string form of cfg.binary used path expansion, while table entries were passed through without expansion. The updated code deep-copies the table and iterates through each part, replacing each with its expanded value. This allows shell and path placeholders like $HOME or ~ to be resolved within multi-element binary configurations before command execution.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix binary path expansion' directly and clearly describes the main change in the changeset—expanding binary paths that were previously not being expanded.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pablopunk pablopunk merged commit 4ba6db0 into pablopunk:main May 18, 2026
5 checks passed
@pablopunk

Copy link
Copy Markdown
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants