fix: defer Active Record patching via ActiveSupport.on_load#61
Open
MattyMc wants to merge 1 commit into
Open
Conversation
Previously, requiring the gem force-loaded active_record/type/json during Bundler.require, before app initializers, so initializers that configure the JSON encoder (e.g., Oj::Rails.set_encoder) had no effect on json/jsonb columns in some Rails versions (e.g. 8.1.2). Now the patches load when ActiveRecord::Base does. Closes palkan#60
Author
|
Note: the railsmaster CI failure is not caused by this change. It also happens on an untouched master checkout. The latest pglite gem (0.1.1) is missing some connection methods that the latest Rails now calls (close, finished?, status) and its WASM build crashes when Rails sets the session time zone, which edge Rails now does on every new connection. It can be safely ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, requiring the gem force-loaded
active_record/type/jsonduringBundler.require, before app initializers, so initializers that configure the JSON encoder (e.g.,Oj::Rails.set_encoder) had no effect on json/jsonb columns in some Rails versions (e.g. 8.1.2). Now the patches load whenActiveRecord::Basedoes.This follows Rails’ recommended pattern for applying configuration to framework classes: use a lazy load hook to avoid autoloading the class before initialization has completed. See the Rails guide note on Avoid Loading Rails Frameworks.
Fixes #60