fix: use os.startfile on Windows instead of subprocess start#3320
Closed
MAXDVVV wants to merge 1 commit intopallets:mainfrom
Closed
fix: use os.startfile on Windows instead of subprocess start#3320MAXDVVV wants to merge 1 commit intopallets:mainfrom
MAXDVVV wants to merge 1 commit intopallets:mainfrom
Conversation
On Windows, 'start' is a shell built-in command, not an executable. subprocess.call(['start', ...]) without shell=True fails with '[WinError 2] The system cannot find the file specified'. Replace with os.startfile() which is the native Python API for opening files/URLs on Windows. Add webbrowser.open fallback for HTTP(S) URLs if startfile fails. Fixes pallets#2868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
click.launch("https://example.com")fails on Windows with[WinError 2] The system cannot find the file specifiedsince version 8.1.8.This is because
startis a Windows shell built-in command, not an executable file. The migration fromos.system()tosubprocess.call()in #1477 broke this —subprocess.call(["start", ...])requiresshell=Trueto work, but the maintainers correctly don't want to useshell=True.Fix
Replace
subprocess.call(["start", ...])withos.startfile(), which is the native Python API for opening files and URLs on Windows. It calls the WindowsShellExecuteWAPI directly without needing a shell.os.startfile(url)directlysubprocess.call(["explorer", "/select,..."])(explorer.exe is a real executable)os.startfilefails withOSError, falls back towebbrowser.open()for HTTP(S) URLs (same pattern as the Linux/xdg-open fallback)Test
Added
test_open_url_windows_uses_startfile— monkeypatchesos.startfileand verifies it's called with the URL.Fixes #2868