Skip to content

Pre-8.4.2 release changelog and doc fixes#3498

Merged
Rowlando13 merged 8 commits into
pallets:stablefrom
kdeldycke:8.4.2-doc-fixes
May 30, 2026
Merged

Pre-8.4.2 release changelog and doc fixes#3498
Rowlando13 merged 8 commits into
pallets:stablefrom
kdeldycke:8.4.2-doc-fixes

Conversation

@kdeldycke
Copy link
Copy Markdown
Collaborator

@kdeldycke kdeldycke commented May 22, 2026

Inconsistencies I spotted after 8.4.1 release:

This is a WIP PR that I will use along the stable branch development cycle and is to be merged before its release.

Before removing the draft status, review all changes in the pending release diff: 8.4.1...stable

Follow up on #3495.

@kdeldycke kdeldycke marked this pull request as draft May 22, 2026 07:28
@kdeldycke kdeldycke added the docs label May 22, 2026
@kdeldycke kdeldycke added this to the 8.4.2 milestone May 22, 2026
@kdeldycke
Copy link
Copy Markdown
Collaborator Author

@Rowlando13 is the empty header element introduced at https://github.com/pallets/click/pull/3447/changes#diff-b4d68dc855d0f9476d3f2ee343853bd21bf82ea9960d0cf06661baa244439dd6R1 intentional? In which case I backported the original rST markup in this PR with 86d6015

@Rowlando13
Copy link
Copy Markdown
Collaborator

Yes. The Sphinx role that was used before is either not supported or has a bug in myst. It is to not have a header on the landing page.

@Rowlando13
Copy link
Copy Markdown
Collaborator

But looks like you fixed it properly so all good.

@kdeldycke
Copy link
Copy Markdown
Collaborator Author

I rebased this PR, so I guess you can merge it if you think we are approaching the 8.4.2 release. The only left over are typing releases, so no changelog required for these.

@kdeldycke kdeldycke marked this pull request as ready for review May 29, 2026 08:30
@kdeldycke kdeldycke changed the title WIP: pre-8.4.2 release changelog and doc fixes Pre-8.4.2 release changelog and doc fixes May 29, 2026
@Rowlando13 Rowlando13 merged commit e02a981 into pallets:stable May 30, 2026
12 checks passed
@kdeldycke kdeldycke deleted the 8.4.2-doc-fixes branch May 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants