Open
Conversation
In `src/yaml_c_wrapper.cpp` the `expand_internal()` function was creating a brand new empty `YAML::Node(Map)` and re-inserting all entries from a cloned map. This unnecessary reconstruction could lose insertion order because re-inserting keys by string into a fresh node goes through `yaml-cpp`'s map lookup path, which doesn't guarantee the same ordering as the source. The fix modifies map values in-place on the already-cloned `new_map` node instead of rebuilding a new map, preserving `yaml-cpp`'s internal insertion order throughout lattice expansion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
src/yaml_c_wrapper.cpptheexpand_internal()function was creating a brand new emptyYAML::Node(Map)and re-inserting all entries from a cloned map. This unnecessary reconstruction could lose insertion order because re-inserting keys by string into a fresh node goes throughyaml-cpp's map lookup path, which doesn't guarantee the same ordering as the source.The fix modifies map values in-place on the already-cloned
new_mapnode instead of rebuilding a new map, preservingyaml-cpp's internal insertion order throughout lattice expansion.Fix #18