Full management of Topology Maps (#15)#16
Merged
Conversation
- Topology now implements IPatchable (enables PatchAsync/UpdateAsync/DeleteAsync) - New TopologyCreationDto for CreateAsync<Topology> - GetTopologyAsync(int id) single-item getter - TopologyLayoutMode gains RADIAL (existing maps use it; was un-round-trippable) - TopologyTests.Crud: create group -> create map (seeded view) -> get -> patch -> delete Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
🟢 Metrics 17 complexity
Metric Results Complexity 17
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Adds the missing pieces for programmatic Topology map (not just group) management.
Changes
Topology : IPatchable— enablesPatchAsync/UpdateAsync/DeleteAsyncon a map.TopologyCreationDto : CreationDto<Topology>— enablesCreateAsync<Topology>(...); exposesname, groupId, views, layout, connections, isCollapseEdges, isDisplayRelatedVertices, showAlertStatus, showEdgeStatus, showUndiscovered, sharable, hiddenVertices, groupBy, edgeStatusConfig. Defaultssharable=true(API-only accounts cannot own private items),isCollapseEdges=true,showAlertStatus=true.GetTopologyAsync(int id)— single-item getter (GET topology/topologies/{id}).TopologyLayoutMode.Radial("RADIAL") — the existing store maps useRADIAL, which previously could not be round-tripped by the enum.TopologyTests.Crud— create group → seed a view from a live device → create map →GetTopologyAsync→PatchAsync→ delete.Testing
dotnet build --configuration Releasesucceeds (0 warnings, 0 errors); packageLogicMonitor.Api.3.240.11produced.TopologyGroupTests.Crudpattern (runs against the CI test portal).Downstream
Unblocks
panoramicdata/PanoramicData.Skills#427(logicmonitor skill topology commands), which unblocks the Store Map Manager inpanoramicdata/LogicMonitor.LogicModules. A tagged release publishing the NuGet is required before the skill can consume these APIs.🤖 Generated with Claude Code