Update TypeScript version in typings tests#3989
Open
nlqivision wants to merge 1 commit into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescript@latestis a moving target which has moved to v6 which in turn breaks a project dependency (karma-typescript) and fails the type tests.Being compatible with latest version ts versions is desirable, but should not break predictability in CI. If support for newest version is wanted we should plan to replace the deprecated karma-typescript package and add v6 to the matrix in a separate PR.
Current workflow blocks security patches and PR's:
#3988 #3985 #3976 #3975 #3973 #3972 #3971