feat(cli): auto-claim user store during registration by sphamjoli · Pull Request #134 · paritytech/dotns-sdk

sphamjoli · 2026-05-13T02:48:32Z

Summary

Refreshes StoreFactory.json for the redesigned factory (split into protocol-managed LabelStore and user-claimed UserStore).
Removes displayDeployedStore and ensureStoreAuthorizations, both of which called selectors that no longer exist on chain and were misreported as "origin not mapped" failures.
Adds claimUserStoreIfNeeded, which reads getUserStore and claims one for the signer if absent. The two prior register stages collapse into a single "Claiming user store" step.

Test plan

bun run --cwd packages/cli test tests/integration/register/register.test.ts
dotns register domain --name <new> shows the claimed user store address
Re-running dotns register domain for the same account does not re-claim

Order

Third in the stack. Base is spha/cli-remove-setpop (#133). The dotns store subcommand still uses the old single-store API and is out of scope here.

github-actions · 2026-05-13T02:48:44Z

CI Summary

Check	Result
Lint	Passed
Format	Passed
Typecheck	Passed
Build	Passed
Release	Passed
Deploy Example	Failed
PR Title	Passed
Labels	Passed
Test	Passed - 154 passed, 0 failed

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 25801765182 -n cli-release-0.0.0-pr.134 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.134.tgz

Verify:

dotns --help

Deploy Example — Failed

Failed at: Deploy — Deploy workflow failed — see run logs for upload/register/contenthash details

Stage	Status
✓ Site validation	Site validated
✗ Deploy	Deploy workflow failed — see run logs for upload/register/contenthash details

View run

Labels

pkg: cli

Test - Passed

154 passed, 0 failed across 154 tests.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [14.00ms]
(pass) text view --help shows name and key arguments [4.00ms]
(pass) text set --help shows name, key, and value arguments [3.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [3.00ms]
(pass) text set --help shows --json option [2.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [3.00ms]

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [2.00ms]
(pass) content set --help shows --json option [2.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>         DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>     Alias for --env\n  --rpc <wsUrl>               WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>      Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --min-balance <pas>         Minimum balance in PAS (env:\n                              DOTNS_MIN_BALANCE_PAS)\n  --account <name>            Keystore account name (default: keystore default)\n  --password <pw>             Keystore password (env: DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>     BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>         Substrate key URI (env: DOTNS_KEY_URI)\n  -h, --help                  display help for command\n\nCommands:\n  view [options] <name>       View domain content hash\n  set [options] <name> <cid>  Set domain content hash (IPFS CID)\n  help [command]              display help for command\n",
}
(pass) content --help lists subcommands and auth options [2.00ms]
(pass) content view --help shows name argument and options [1.00ms]
(pass) content set --help shows name and cid arguments [2.00ms]

::endgroup::

::group::tests/unit/utils/formatting.test.ts:
(pass) native balance formatting uses DOT/PAS 10 decimals > defaults to 10 native decimals and 18 EVM decimals
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders 5000 PAS from 5000 * 10^10 units [1.00ms]
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders fractional 0.1 PAS as 10^9 units
(pass) native balance formatting uses DOT/PAS 10 decimals > formatNativeBalance renders zero balance
(pass) native balance formatting uses DOT/PAS 10 decimals > parseNativeBalance inverts formatNativeBalance
(pass) native balance formatting uses DOT/PAS 10 decimals > parseNativeBalance('0.1') is 10^9

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) isRevertFlag matches the EVM revert bit > flags=0n → false
(pass) isRevertFlag matches the EVM revert bit > flags=1n → true
(pass) isRevertFlag matches the EVM revert bit > flags=2n → false
(pass) isRevertFlag matches the EVM revert bit > flags=3n → true
(pass) buildRevertError > empty data returns the unmapped-origin hint [1.00ms]
(pass) buildRevertError > known ABI selector decodes to the named error [6.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [1.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [326.01ms]
(pass) auth set accepts account names with special characters [476.01ms]
(pass) auth list reports missing keystore [5.00ms]
(pass) auth list shows all accounts and auth types [310.01ms]
(pass) auth use switches default account [470.01ms]
(pass) auth remove last account clears default [83.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [233.00ms]
(pass) auth clear deletes all accounts [94.00ms]

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [2.00ms]
(pass) auth help shows options and subcommands [2.00ms]
(pass) auth set help shows all options [2.00ms]
(pass) auth list help shows options [1.00ms]
(pass) auth use help shows options [2.00ms]
(pass) auth remove help shows options [2.00ms]
(pass) auth clear help shows options [2.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [2.00ms]
(pass) auth set parses account option [2.00ms]
(pass) auth set parses mnemonic option [2.00ms]
(pass) auth set parses key-uri option [2.00ms]
(pass) auth help command shows help [2.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [1.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help [1.00ms]
(pass) auth help clear shows clear command help [2.00ms]

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [3.00ms]
(pass) auth set rejects account name with backslash [1.00ms]
(pass) auth set rejects account name that is just a dot [2.00ms]
(pass) auth set rejects account name that is double dots [1.00ms]
(pass) auth set rejects account name starting with dot [2.00ms]
(pass) auth set rejects account name ending with dot [1.00ms]
(pass) auth set rejects account name with special characters [10.00ms]
(pass) auth set rejects account name that is too long [1.00ms]
(pass) auth use rejects non-existent account [74.00ms]
(pass) auth remove rejects non-existent account [90.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label [1.00ms]
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [1.00ms]
(pass) store info --help shows auth options [2.00ms]
(pass) store list --help shows options [1.00ms]
(pass) store get --help shows key argument [1.00ms]
(pass) store set --help shows key and value arguments with auth [1.00ms]
(pass) store delete --help shows key argument with auth [1.00ms]
(pass) store check --help shows address argument [2.00ms]
(pass) store authorize --help shows address argument with auth [1.00ms]
(pass) store unauthorize --help shows address argument [1.00ms]
(pass) store authorize-controller --help shows address argument [1.00ms]
(pass) store unauthorize-controller --help shows address argument [1.00ms]
(pass) store ensure-auth --help shows description and auth options [1.00ms]

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [1.00ms]
(pass) pop status --help shows --json option [2.00ms]

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [1.00ms]
(pass) pop help shows commands and description [1.00ms]
(pass) pop help shows auth options [2.00ms]
(pass) pop info help shows description [2.00ms]
(pass) pop status help shows description [1.00ms]
(pass) pop info help shows auth options [2.00ms]
(pass) pop info parses auth options at pop level [1.00ms]
(pass) pop info parses auth options at info level [1.00ms]
(pass) pop help command shows pop help [2.00ms]
(pass) pop help status shows info help [1.00ms]
(pass) pop help info shows info help [1.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped, is-whitelisted, whitelist [2.00ms]
(pass) account is-mapped --help shows address argument and --json [1.00ms]
(pass) account is-whitelisted --help shows address argument and --json [1.00ms]
(pass) account whitelist --help shows address argument, --remove, and --json [1.00ms]
(pass) account is alias works for is-mapped [1.00ms]
(pass) account iw alias works for is-whitelisted [1.00ms]

::endgroup::

::group::tests/unit/cli/reporter.test.ts:
(pass) cli reporter > stream reporter emits durable progress lines
(pass) cli reporter > withConsoleToStderr redirects console and stdout writes [1.00ms]

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2
(pass) accepts friendly paseo-v2 aliases
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [2.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index [2.00ms]

::endgroup::

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [16.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/bulletin/bulletinHelp.test.ts:
(pass) root help lists bulletin command [2.00ms]
(pass) bulletin help shows commands and description [1.00ms]
(pass) bulletin upload help shows all options [1.00ms]
(pass) bulletin upload help shows default values [2.00ms]
(pass) bulletin authorize help shows all options [1.00ms]
(pass) bulletin authorize help shows default values [1.00ms]
(pass) bulletin history help shows options [1.00ms]
(pass) bulletin history:remove help shows usage [1.00ms]
(pass) bulletin history:clear help shows description [1.00ms]
(pass) bulletin help command shows bulletin help [1.00ms]
(pass) bulletin help upload shows upload help [1.00ms]
(pass) bulletin help authorize shows authorize help [1.00ms]
(pass) bulletin status help shows all options [1.00ms]
(pass) bulletin help status shows status help [1.00ms]
(pass) bulletin list alias works [1.00ms]
(pass) bulletin verify help shows usage [1.00ms]
(pass) bulletin help verify shows verify help [1.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [2.00ms]
(pass) register help shows subcommands [1.00ms]
(pass) register domain help shows options [2.00ms]
(pass) register subname help shows options [1.00ms]
(pass) register domain parses reverse flag [1.00ms]
(pass) register domain parses governance flag [2.00ms]
(pass) register domain parses owner option [2.00ms]
(pass) register domain parses transfer with destination [1.00ms]
(pass) register domain parses account option [1.00ms]
(pass) register domain parses keystore-path option [1.00ms]
(pass) register domain parses password option [1.00ms]
(pass) register domain parses mnemonic option [2.00ms]
(pass) register domain parses key-uri option [1.00ms]
(pass) register domain parses commitment-buffer option [1.00ms]
(pass) register domain parses commitment-buffer alias --cb [1.00ms]
(pass) register subname parses name and parent [1.00ms]
(pass) register subname parses owner option [1.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [2.00ms]
(pass) register subname --help shows --json option [1.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [2.00ms]

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [2.00ms]
(pass) lookup name --help shows label argument and options [1.00ms]
(pass) lookup owner-of --help shows label argument and options [1.00ms]
(pass) lookup transfer --help shows label argument and destination option [1.00ms]
(pass) lookup transfer parses destination at transfer level [1.00ms]
(pass) lookup transfer parses auth options at lookup level [2.00ms]

::endgroup::

 154 pass
 0 fail
 565 expect() calls
Ran 154 tests across 22 files. [2.80s]

The `StoreFactory` on the latest deployment splits storage into a protocol-managed `LabelStore` (deployed automatically by the registrar) and a user-claimed `UserStore`. The CLI previously called the removed `getDeployedStore` selector and tried to authorise the store as a registrar writer, both of which now revert. This PR refreshes `StoreFactory.json`, removes the obsolete `displayDeployedStore` / `ensureStoreAuthorizations` helpers, and adds `claimUserStoreIfNeeded` which reads `getUserStore` and claims it for the signer if none exists. The two-step "Displaying store" + "Ensuring store authorizations" stage in the register flow collapses into a single "Claiming user store" step. Depends on the previous two PRs (multi-env + setPop removal).

andrew-ifrita

Looks good to me. I just rebased on main because github was showing conflicts

andrew-ifrita · 2026-05-13T13:39:53Z

CI is failing but looks like it is because the account deploying isnt whitelisted or have a PoPStatus. Will merge now and address later

## Summary - Reads renamed `transactions` / `bytes` fields from `AuthorizationExtent` (the `_allowance` aliases no longer exist on the new chain types). This clears the lingering type errors on `main`. - Updates the CLI README to reflect the env-aware command surface. - Tidies the UI doc pages, register modal, error display, profile view, and IPFS helper. ## Test plan - [ ] `bun run --cwd packages/cli typecheck` - [ ] `bun run --cwd packages/cli test tests/integration/bulletin` - [ ] Skim the rendered CLI page in the UI ## Order Last in the stack. Base is `spha/cli-auto-claim-user-store` (#134).

sphamjoli requested review from andrew-ifrita and waytwotall as code owners May 13, 2026 02:48

github-actions Bot requested review from corey-hathaway and filvecchiato May 13, 2026 02:48

github-actions Bot added the pkg: cli label May 13, 2026

sphamjoli mentioned this pull request May 13, 2026

chore(cli): refresh docs and bulletin allowance field reads #135

Merged

3 tasks

Base automatically changed from spha/cli-remove-setpop to main May 13, 2026 13:13

andrew-ifrita force-pushed the spha/cli-auto-claim-user-store branch from 1118da0 to 0b4f813 Compare May 13, 2026 13:20

andrew-ifrita approved these changes May 13, 2026

View reviewed changes

andrew-ifrita merged commit 05adce5 into main May 13, 2026
20 of 22 checks passed

andrew-ifrita deleted the spha/cli-auto-claim-user-store branch May 13, 2026 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): auto-claim user store during registration#134

feat(cli): auto-claim user store during registration#134
andrew-ifrita merged 1 commit into
mainfrom
spha/cli-auto-claim-user-store

sphamjoli commented May 13, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 13, 2026 •

edited

Loading

Uh oh!

andrew-ifrita left a comment

Uh oh!

andrew-ifrita commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sphamjoli commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Order

Uh oh!

github-actions Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary

Uh oh!

andrew-ifrita left a comment

Choose a reason for hiding this comment

Uh oh!

andrew-ifrita commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sphamjoli commented May 13, 2026 •

edited

Loading

github-actions Bot commented May 13, 2026 •

edited

Loading