fix(e2e): update pr-mod test for signer-less dot mod#172
Closed
EnderOfWorlds007 wants to merge 1 commit into
Closed
fix(e2e): update pr-mod test for signer-less dot mod#172EnderOfWorlds007 wants to merge 1 commit into
EnderOfWorlds007 wants to merge 1 commit into
Conversation
Since b228817 (feat: migrate to paseo-next-v2), dot mod uses getReadOnlyRegistryContract and never calls resolveSigner. The --suri flag is a deprecated no-op. The test "exits non-zero with signer suggestion when no signer available" was asserting on "No signer available" output that no longer exists. Update the test to reflect the actual signer-less behavior: dot mod proceeds directly to the registry lookup, and an unknown domain produces "not found in registry" (not a signer error).
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ❌ FAILTag:
❌ Failed tests (1)
Sentry traces: view spans for this run |
Collaborator
Author
|
Closing in favor of #171 which now includes both the domain rename and the mod test fix (cherry-picked from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: migrate to paseo-next-v2, 2026-05-13),dot modusesgetReadOnlyRegistryContractand never callsresolveSigner—--suriis a deprecated no-oppr-modCI cell was failing because the test"exits non-zero with signer suggestion when no signer available"assertedoutput.toContain("No signer available")— output that no longer existsdot modproceeds directly to the registry lookup, and an unknown domain produces"not found in registry"Test plan
pr-modcell passes