fix(e2e): tag chaos deploy transactions as e2e in bulletin-deploy dashboard#174
Merged
Conversation
…hboard Both chaos tests spawn the CLI via execa directly (not the dot() helper) to get a signalable child handle. The dot.ts helper normally computes DEPLOY_TAG from DOT_TAG — without it, bulletin-deploy spans are emitted with no deploy.tag, making chaos transactions appear as real-user traffic in the bulletin-deploy Sentry dashboard. Add DEPLOY_TAG to both env objects, mirroring dot.ts's derivation: e2e-cli-chaos-sigint (SIGINT test) e2e-cli-chaos-rpc (RPC failover test) Respects any explicit DEPLOY_TAG override from the outer environment.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both chaos tests (
nightly-chaos-sigint,nightly-chaos-rpc) spawn the CLI viaexecadirectly — not through thedot()helper — so they can get a signalable child handle. Thedot.tshelper normally computesDEPLOY_TAGfromDOT_TAGbefore spawning; without it, bulletin-deploy emits spans with nodeploy.tag, making chaos transactions appear as real-user traffic in bulletin-deploy's Sentry dashboard.Adds
DEPLOY_TAGto bothenvobjects, mirroring the derivation indot.ts:e2e-cli-chaos-sigintfor the SIGINT mid-deploy teste2e-cli-chaos-rpcfor the RPC failover testRespects any explicit
DEPLOY_TAGoverride from the outer environment (consistent withdot.tsbehaviour).Test plan
deploy.tag:e2e-cli-chaos-*spans visible in bulletin-deploy's E2E dashboard