Skip to content

fix: updates in diagnosis report + submit report button#277

Merged
Imod7 merged 3 commits into
mainfrom
playground-diagnosis
Jul 16, 2026
Merged

fix: updates in diagnosis report + submit report button#277
Imod7 merged 3 commits into
mainfrom
playground-diagnosis

Conversation

@Imod7

@Imod7 Imod7 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

  • The diagnosis screen and its exported report mark skipped methods as failed (with the reason they were skipped), so every truapi method appears in the compatibility matrix instead of being dropped.
  • The "Submit report" button keeps the issue URL under GitHub's length limit (full report to the clipboard, compact variant in the URL).
  • Also fixes a broken example payload that made one signing method fail to load on a phone.

Changes

  • playground/src/lib/auto-test.ts - skipped methods carry a short reason ("service not yet wired up by hosts" / "host surface intentionally deferred") so the Details column isn't empty.
  • playground/src/lib/diagnosis-report.ts - the report has a N success · N failed summary line; skipped methods are listed as failed () with their reason so they stay in the compatibility matrix (the aggregator keeps only / cells). Adds a compact mode (drops success details) and a URL-length cap: if the report is still too big, the issue opens with a "paste from clipboard" note instead of failing.
  • playground/src/components/DiagnosisView.tsx - the on-screen diagnosis shows skipped methods as failed with their reason; the summary is N success · N failed. "Submit report" copies the full report to the clipboard and puts the compact variant (success details dropped) in the issue URL.
  • rust/crates/truapi/src/api/signing.rs - fixes the sign_payload_with_legacy_account example, which used an incomplete call payload the phone couldn't decode ("fails to load"). Now uses the same valid payload as sign_payload.
  • playground/tests/e2e/dotli-diagnosis.ts - the e2e hard-fail gate excludes intentionally-skipped rows (data-skipped), so only genuine failures fail the run.
  • playground/CLAUDE.md - updates the file descriptions to match the above.

Notes

  • Skipped methods appear as failed () in the compatibility matrix, so every truapi method stays in the grid; the reason a method was skipped is preserved in the report's Details column. In the matrix grid an intentional skip and a genuine failure look identical — the distinction only survives in the Details column.
  • The full report is always on the clipboard, so nothing is lost when the URL falls back to the paste note.

@Imod7
Imod7 requested a review from a team July 14, 2026 15:16
Comment thread playground/src/lib/diagnosis-report.ts Outdated
@Imod7
Imod7 added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 9a501f4 Jul 16, 2026
12 checks passed
@Imod7
Imod7 deleted the playground-diagnosis branch July 16, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants