fix(truapi): treat Firefox's masked "null" ancestor origin as hidden#283
Merged
Conversation
Firefox implements location.ancestorOrigins but serializes cross-origin
ancestors as the literal string "null", which resolveHostOrigin returned
verbatim; the sandbox bootstrap then threw SyntaxError ("An invalid or
illegal string was specified") from parent.postMessage and every client
call inside an iframe host failed. Treat "null" as an unknown host origin
and fall through to the source-checked wildcard ready ping so the
handshake completes on Firefox.
valentinfernandez1
marked this pull request as ready for review
July 16, 2026 15:11
pgherveou
approved these changes
Jul 16, 2026
7 tasks
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Firefox reports cross-origin ancestors in
location.ancestorOriginsas the literal string"null". The sandbox bootstrap passed that straight toparent.postMessageas the targetOrigin for itstruapi-readyping, which throwsSyntaxError: An invalid or illegal string was specified, so the handshake never completed and every TrUAPI call failed in Firefox iframe hosts. Chrome was unaffected because it reports the real ancestor origin.resolveHostOrigin()now treats"null"as "host origin unknown" and uses the existing wildcard ready ping instead.