refactor: split impls into feature-grouped impls module#248
Closed
danielbui12 wants to merge 4 commits into
Closed
refactor: split impls into feature-grouped impls module#248danielbui12 wants to merge 4 commits into
danielbui12 wants to merge 4 commits into
Conversation
Move the 42 Pallet<T> helper and runtime-API query methods out of the monolithic helper impl block in lib.rs into pallet/src/impls/, grouped by feature across 9 files (signatures, members, providers, buckets, agreements, challenges, checkpoints, queries, marketplace), declared from impls/mod.rs. All methods are now pub: once they live in a sibling module, the dispatchables in lib.rs reach them via Self::, so private/pub(crate) visibility would no longer compile. Pure move + visibility change; behavior is unchanged and all 194 pallet tests pass.
danielbui12
marked this pull request as draft
June 30, 2026 04:40
Extract challenge_to_response helper so the ChallengeResponse construction lives in one place instead of being copy-pasted across four query functions. Move the bucket_id/provider/challenger filters ahead of the map so encoding only runs on matching challenges.
Collaborator
@danielbui12 my bad, sorry, I should have been more explicit, I meant to open this PR (+ #249) to the @danielbui12 can you please join #248 + #249 to the one and open against |
Member
Author
|
@bkontur but the 248 + 249 include changes from 239 as well (using storage-subxt). do you want me to take runtime api changes to another branch based on dev? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #239 (comment)