Skip to content

ci(migrations): confine snapshot cache lookup to a 3-day date window #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkontur merged 2 commits into from
Jul 14, 2026
Merged

ci(migrations): confine snapshot cache lookup to a 3-day date window #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eee9a7
ci(migrations): confine snapshot cache lookup to a 3-day date window
danielbui12 Jul 14, 2026
d17f657
chore: minimize the docs
danielbui12 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 30 additions & 16 deletions .github/workflows/check-runtime-migration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,22 +109,29 @@ jobs:
- name: Load common environment variables via env file
run: cat .github/env >> $GITHUB_ENV

# Snapshot lookup uses a deliberately-non-matching primary `key:` so
# `restore-keys` always falls through to the most recent dated entry.
# With `lookup-only` the snapshot isn't restored — we just decide whether
# to regenerate. `cache-matched-key` is empty iff nothing was found, which
# is also the case on the daily `schedule` (lookup skipped) so the
# snapshot is force-refreshed nightly.
# The lookup is date-bounded because an unbounded prefix restore would
# let a stale PR-scoped snapshot shadow fresh dev-scoped ones forever.
# `cache-matched-key` is empty on a miss and on the nightly `schedule`
# (lookup skipped), forcing a snapshot refresh.
- name: Compute snapshot date window
id: dates
shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> "$GITHUB_OUTPUT"
echo "yesterday=$(/bin/date -u -d '1 day ago' '+%Y%m%d')" >> "$GITHUB_OUTPUT"
echo "daybefore=$(/bin/date -u -d '2 days ago' '+%Y%m%d')" >> "$GITHUB_OUTPUT"

- name: Check if snapshot exists in cache
id: cache-restore
if: github.event_name != 'schedule'
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v5
with:
lookup-only: true
path: snapshot.raw
key: try-runtime-snapshot-${{ matrix.runtime.name }}
key: try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.today }}
restore-keys: |
try-runtime-snapshot-${{ matrix.runtime.name }}-
try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.yesterday }}
try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.daybefore }}
fail-on-cache-miss: false

- name: Install just
Expand Down Expand Up @@ -175,18 +182,12 @@ jobs:
sleep 10
done

- name: Get Date
id: get-date
if: steps.cache-restore.outputs.cache-matched-key == ''
run: echo "today=$(/bin/date -u "+%Y%m%d")" >> "$GITHUB_OUTPUT"
shell: bash

- name: Save snapshot to cache
if: steps.cache-restore.outputs.cache-matched-key == ''
uses: actions/cache/save@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v5
with:
path: snapshot.raw
key: try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.get-date.outputs.today }}
key: try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.today }}

check-migrations:
name: check-migration (${{ matrix.runtime.name }})
Expand Down Expand Up @@ -231,11 +232,24 @@ jobs:
if: steps.try-runtime-cache.outputs.cache-hit != 'true'
run: just download-try-runtime

# Same 3-day window as prepare-snapshots: never restore a snapshot more
# than two days old, whatever ref scope it lives in.
- name: Compute snapshot date window
id: dates
shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> "$GITHUB_OUTPUT"
echo "yesterday=$(/bin/date -u -d '1 day ago' '+%Y%m%d')" >> "$GITHUB_OUTPUT"

@bkontur bkontur Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, what if prepare-snapshots: runs before midnight and check-migrations after midnight?

echo "daybefore=$(/bin/date -u -d '2 days ago' '+%Y%m%d')" >> "$GITHUB_OUTPUT"

- name: Restore snapshot from cache
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v5
with:
path: snapshot.raw
key: try-runtime-snapshot-${{ matrix.runtime.name }}-
key: try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.today }}
restore-keys: |
try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.yesterday }}
try-runtime-snapshot-${{ matrix.runtime.name }}-${{ steps.dates.outputs.daybefore }}
fail-on-cache-miss: true

- name: Run ${{ matrix.runtime.name }} Runtime Checks
Expand Down
Loading