refactor: move primitives crates to crates/primitives#292
Draft
danielbui12 wants to merge 2 commits into
Draft
Conversation
- Move primitives/, storage-interfaces/{file-system,s3}/primitives into
crates/primitives/{storage,file-system,s3}; package names unchanged
- Move the two wired examples into the file-system crate (cargo
auto-discovery) and drop their [[example]] path overrides
- Split each lib.rs into per-concept modules (storage: provider/
challenge/mmr/commitment/checkpoint; file-system: proto/bounds/
directory/manifest/convert/error/drive/cid; s3: bounds/bucket/
object/error) re-exported from the crate root, so no consumer changes
- Update workspace member/dependency paths, CI migration paths-filter,
license-header includes, and doc path references
- Note: scale-info type paths in runtime metadata changed; regenerate
crates/storage-subxt bindings via `just subxt-codegen` later (crate
has no consumers yet, SCALE encoding unaffected)
…ives - Move ProviderInfo/ProviderSettings/ProviderStats, Member/Bucket, StorageAgreement, and Challenge/ChallengeResponse into crates/primitives/storage with explicit generics; the pallet keeps same-named T-binding aliases so declarations stay unchanged - Marker-carrying types (ProviderInfo, Bucket, ChallengeResponse) use manual Clone/PartialEq/Eq/Debug impls so Get<u32> markers need no trait impls; ProviderInfo follows the DriveInfo mel_bound() pattern - ProviderSettings serde derives are feature-gated with deserialize bounds carrying Zero + Bounded for the container default attr - storage-primitives gains sp-runtime; pallet enables its serde feature - Add turbofish (::<T>/::<Test>/::<Runtime>) at construction sites where alias inference cannot resolve T through projections (E0284) - Update justfile subxt --derive-for-type paths to the new storage_primitives::provider::* metadata paths (regen still deferred) - SCALE encodings are byte-identical; only metadata type paths change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.