[mtrezza]

Issue

Pre-authentication denial of service via email address format regex backtracking (GHSA-9492-427f-466x)

Tasks

• Add tests

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 6991ebbe-05d4-4b82-a8e9-28bed3ded203

📥 Commits

Reviewing files that changed from the base of the PR and between 7d81c85 and f889a6b.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: fe9613ab-03ee-4acc-9a46-dab7b82de12a

📥 Commits

Reviewing files that changed from the base of the PR and between d7e3087 and 7d81c85.

📒 Files selected for processing: 2

• spec/vulnerabilities.spec.js
• src/RestWrite.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The email-format check now requires characters before and after the at sign and excludes line separators before it. Added tests cover accepted and rejected addresses, including long inputs submitted during sign-up and user updates.

Changes: Email validation

Layer / File(s)	Summary
Email format check and validation tests src/RestWrite.js, spec/vulnerabilities.spec.js	The email-format check constrains the portion before the at sign and still requires characters after it. Tests cover accepted and rejected addresses, plus 100,000-at-sign inputs with a two-second limit.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7d81c

The email validation change is ready to merge after normal checks; no unresolved issue was identified.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

• Ignore

Failed checks: 1 error

Check name	Status	Explanation	Resolution
Description check		The pull request has no description. It omits the required Issue, Approach, and Tasks information, including test and security-check details.	Add a pull request description that follows the repository template. Describe the issue, explain the approach, and mark the applicable Tasks items as complete.

Passed checks: 6 passed

Check name	Status	Explanation
Title check		The title starts with the required fix: prefix. It uses the capitalized identifier GHSA-9492-427f-466x and accurately describes the security fix.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Security Check		The change addresses the reported email-validation ReDoS without adding a new security issue. src/RestWrite.js:1005-1006 replaces the backtracking-prone ^.+@.+$ with ^.[^@\\n\\r\\u2028\\u2029]*@.+$.…
Engage In Review Feedback		PASS: No review feedback comments were returned, and the current review produced zero actionable findings. There was no feedback for the contributor to ignore, resolve, implement, or discuss.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Full details: Security Check

Explanation

The change addresses the reported email-validation ReDoS without adding a new security issue. src/RestWrite.js:1005-1006 replaces the backtracking-prone ^.+@.+$ with ^.[^@\n\r\u2028\u2029]*@.+$. The negated class cannot consume @ or line terminators, so the pre-@ scan is linear; the remaining .+$ has no nested competing quantifier. Direct Node checks rejected all four 100,000-@ payloads and line-terminator cases in under 1 ms. The added tests cover sign-up, user update, and email-format boundaries.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Pre-merge checks failed. Please resolve the failing checks before merging.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (e8ae87a) to head (f889a6b).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha   #10821   +/-   ##
=======================================
  Coverage   94.06%   94.06%           
=======================================
  Files         193      193           
  Lines       17367    17367           
  Branches      259      259           
=======================================
  Hits        16337    16337           
  Misses       1008     1008           
  Partials       22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.10.7-alpha.1

[parseplatformorg]

🎉 This change has been released in version 9.10.7