refactor(wasm): make vide-lsp-wasm own build script and artifacts#308
Open
kunlinglio wants to merge 4 commits into
Open
refactor(wasm): make vide-lsp-wasm own build script and artifacts#308kunlinglio wants to merge 4 commits into
kunlinglio wants to merge 4 commits into
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors browser LSP WASM asset ownership so the vide-lsp-wasm crate becomes the canonical producer and home of the built artifacts (crates/vide-lsp-wasm/dist/), and updates the website/playground, VS Code web packaging, and CI workflows to consume from that new location.
Changes:
- Move WASM build output location to
crates/vide-lsp-wasm/distand update build script accordingly. - Update playground/docs/VS Code web copy steps to source WASM assets from
crates/vide-lsp-wasm/dist. - Update GitHub Actions caches and build steps to build/cache the crate-owned WASM artifacts.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/site/src/content/docs/en/advanced-guide/advanced-installation.md | Updates docs to point to the new crate-owned WASM build script path. |
| website/site/src/content/docs/advanced-guide/advanced-installation.md | Same doc update as above for the non-English docs page. |
| website/playground/scripts/copy-wasm-assets.mjs | Adds a script to copy canonical WASM artifacts from the crate into the playground’s public assets. |
| website/playground/scripts/copy-docs-assets.mjs | Updates docs asset copying to source WASM from crates/vide-lsp-wasm/dist. |
| website/playground/package.json | Adjusts build:wasm to run the crate build script and then copy assets into the playground. |
| editors/vscode/scripts/copy-web-assets.ts | Updates VS Code web asset copy to read from the crate dist directory. |
| crates/vide-lsp-wasm/scripts/build.mjs | Makes the crate build script self-contained and changes output dir to crates/vide-lsp-wasm/dist. |
| crates/vide-lsp-wasm/.gitignore | Ignores the new dist/ output directory. |
| .github/workflows/docs-preview.yml | Updates CI caching/build steps to use crate-owned dist artifacts. |
| .github/workflows/deploy-docs.yml | Same as above for the deploy workflow. |
| .github/workflows/ci.yml | Updates CI cache/build steps to use crate-owned dist artifacts for web smoke tests. |
| .github/workflows/build-artifacts.yml | Updates artifact build workflow to build/cache crate-owned WASM output. |
| .github/ci-modules.yml | Updates CI module path filters to track the moved crate-owned WASM build inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit a7d51ef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the browser LSP WASM build ownership from the website playground package into
crates/vide-lsp-wasm.The WASM artifacts are produced from the
vide-lsp-wasmcrate, so the build script and canonical output directory should live with that crate instead of underwebsite/playground. This makescrates/vide-lsp-wasm/dist/the single source of truth for browser LSP WASM assets.This is a part of directory layout refactor. See #305