-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(ifc): preserve unsupported IFC geometry #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yorhodes
wants to merge
2
commits into
pascalorg:main
Choose a base branch
from
yorhodes:codex/ifc-type-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import dedent from 'dedent' | ||
| import { z } from 'zod' | ||
| import { BaseNode, nodeType, objectId } from '../base' | ||
|
|
||
| const finiteNumber = z.number().finite() | ||
| const vector3Array = z | ||
| .array(finiteNumber) | ||
| .refine((values) => values.length % 3 === 0, 'Expected XYZ triples') | ||
|
|
||
| export const ImportedMeshPrimitive = z.object({ | ||
| positions: vector3Array, | ||
| normals: vector3Array.optional(), | ||
| indices: z.array(z.number().int().nonnegative()).default([]), | ||
| color: z.string().default('#94a3b8'), | ||
| opacity: z.number().min(0).max(1).default(1), | ||
| }) | ||
|
|
||
| export type ImportedMeshPrimitive = z.infer<typeof ImportedMeshPrimitive> | ||
|
|
||
| /** Triangle geometry retained when an import has no native Pascal shape. */ | ||
| export const ImportedMeshNode = BaseNode.extend({ | ||
| id: objectId('imesh'), | ||
| type: nodeType('imported-mesh'), | ||
| position: z.tuple([finiteNumber, finiteNumber, finiteNumber]).default([0, 0, 0]), | ||
| rotation: z.tuple([finiteNumber, finiteNumber, finiteNumber]).default([0, 0, 0]), | ||
| primitives: z.array(ImportedMeshPrimitive).default([]), | ||
| }).describe( | ||
| dedent` | ||
| Imported mesh node - triangle geometry preserved from an external model | ||
| - position / rotation: transform in the parent coordinate system | ||
| - primitives: indexed triangle buffers in meters with source display colors | ||
| - metadata: source-format identity and properties | ||
| `, | ||
| ) | ||
|
|
||
| export type ImportedMeshNode = z.infer<typeof ImportedMeshNode> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import type { DoorNode } from '@pascal-app/core' | ||
|
|
||
| type DoorStyle = Partial<DoorNode> | ||
|
|
||
| const glazedSegments: DoorNode['segments'] = [ | ||
| { | ||
| type: 'glass', | ||
| heightRatio: 1, | ||
| columnRatios: [1], | ||
| dividerThickness: 0.025, | ||
| panelDepth: 0.008, | ||
| panelInset: 0.035, | ||
| }, | ||
| ] | ||
|
|
||
| /** Map standardized IfcDoor operation values to Pascal door families. */ | ||
| export function doorStyleFromIfcOperation(operationType: unknown): DoorStyle { | ||
| const operation = String(operationType ?? '').toUpperCase() | ||
| const leafCount = operation.startsWith('DOUBLE_DOOR') ? 2 : 1 | ||
|
|
||
| if (operation.includes('SLIDING')) { | ||
| return { | ||
| doorType: 'sliding', | ||
| leafCount, | ||
| slideDirection: operation.includes('RIGHT') ? 'right' : 'left', | ||
| trackStyle: 'visible', | ||
| threshold: false, | ||
| } | ||
| } | ||
|
|
||
| if (operation.includes('FOLDING')) { | ||
| return { | ||
| doorType: 'folding', | ||
| leafCount: 2, | ||
| } | ||
| } | ||
|
|
||
| if (operation === 'ROLLINGUP') { | ||
| return { | ||
| doorCategory: 'garage', | ||
| doorType: 'garage-rollup', | ||
| trackStyle: 'overhead', | ||
| } | ||
| } | ||
|
|
||
| if (operation.startsWith('DOUBLE_DOOR')) { | ||
| return { doorType: 'double', leafCount: 2 } | ||
| } | ||
|
|
||
| if (operation.includes('SWING_RIGHT')) return { hingesSide: 'right' } | ||
| if (operation.includes('SWING_LEFT')) return { hingesSide: 'left' } | ||
| return {} | ||
| } | ||
|
|
||
| /** Apply the standardized Pset_DoorCommon glazing fraction after psets load. */ | ||
| export function doorGlazingStyle(door: DoorNode, glazingAreaFraction: unknown): DoorStyle { | ||
| const fraction = Number(glazingAreaFraction) | ||
| if (!Number.isFinite(fraction) || fraction <= 0) return {} | ||
|
|
||
| return { | ||
| doorType: door.doorType === 'double' ? 'french' : door.doorType, | ||
| segments: glazedSegments, | ||
| contentPadding: [0.04, 0.05], | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing material allows wall merge
Medium Severity
wallMaterialCompatibletreats a missingmetadata.materialon either wall as compatible and allows merge. Collinear exterior and interior fragments can combine when only one side received an IFC material association, undoing the intent of the new material guard.Reviewed by Cursor Bugbot for commit 3449f30. Configure here.