isp: enable sensor power via ACPI and make set file load non-fatal#324
Open
CleoMenezesJr wants to merge 1 commit into
Open
isp: enable sensor power via ACPI and make set file load non-fatal#324CleoMenezesJr wants to merge 1 commit into
CleoMenezesJr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacBook Air (BCM1570), probe fails with error -5 because the ISP rejects CISP_CMD_CH_SET_FILE_LOAD with 0xfffe (UNKNOWN COMMAND).
isp_enable_sensor()was a no-op, now powers on the sensor CMOS via ACPI CMPE + 100 ms delay before ISP initCISP_CMD_CH_SET_FILE_LOAD failure is now non-fatal, consistent with the existing comment "The set file is allowed to be missing"
Tested on MacBook Air A1466 (Mid 2013), Fedora 44, kernel 7.0.4.
Fixes #321.