Skip to content

fix(tools)!: remove cem/a config#2912

Merged
bennypowers merged 38 commits into
mainfrom
fix/remove-cem
Jul 16, 2025
Merged

fix(tools)!: remove cem/a config#2912
bennypowers merged 38 commits into
mainfrom
fix/remove-cem

Conversation

@bennypowers

Copy link
Copy Markdown
Member

What I did

  1. removed custom elements manifest analyzer config
  2. replace cem/a with @pwrs/cem

Testing Instructions

  1. see that the deploy preview has the same element api docs as patternflyelements.org

@changeset-bot

changeset-bot Bot commented Jun 17, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e50534

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/pfe-core Patch
@patternfly/pfe-tools Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tools)!: remove cem/a config"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label Jun 17, 2025
@github-actions

github-actions Bot commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 30b9be1
😎 Deploy Preview https://deploy-preview-2912--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 8b52d25: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 9cca1bd: Report

@netlify

netlify Bot commented Jun 18, 2025

Copy link
Copy Markdown

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 6e50534
🔍 Latest deploy log https://app.netlify.com/projects/patternfly-elements/deploys/687741ae0e9b3400087948c9
😎 Deploy Preview https://deploy-preview-2912--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for ef99827: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 95b67a9: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 29e3532: Report

@bennypowers

Copy link
Copy Markdown
Member Author

We might need to npm I @pwrs/cem in CI

As long as it works normally on someone's laptop, with npm CI, I don't mind just leaving a comment on a workflow file.

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 16f58bb: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 69010a6: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for c05ccdb: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 1d01cc1: Report

@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 97d11a5: Report

@github-actions

This comment has been minimized.

@bennypowers bennypowers enabled auto-merge (squash) July 16, 2025 06:04
@github-actions

Copy link
Copy Markdown
Contributor

SSR Test Run for 30b9be1: Report

@bennypowers bennypowers changed the title fix(tools)!: remove cem config fix(tools)!: remove cem/a config Jul 16, 2025
@ArathyKumar ArathyKumar self-requested a review July 16, 2025 07:42

@ArathyKumar ArathyKumar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@bennypowers bennypowers merged commit 2cf37ca into main Jul 16, 2025
16 checks passed
@bennypowers bennypowers deleted the fix/remove-cem branch July 16, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants