FIX: updated json deserialization code - #2
Merged
Elijah Skeirik (payablijah) merged 7 commits intoJul 20, 2026
Conversation
….com/payabli/sdk-php into elijah/doc-2350-fix-json-deserialize
…rialization JsonSerializableType::jsonSerialize() returns array|stdClass, but PushPayLinkRequest passed the result directly to array_merge(), which only accepts arrays. This fixes the composer analyze (PHPStan) CI failure by normalizing to arrays before merging and tightening the unknown-branch typing in jsonSerialize()/jsonDeserialize(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…onSerialize jsonSerialize() unconditionally re-passed already-serialized Union/ArrayType values through serializeObject(), which requires a JsonSerializable instance. An empty map or empty union member serializes to a plain stdClass, which isn't JsonSerializable, so re-processing it threw "Class stdClass must implement JsonSerializable." Skip the object-handling branch once a value has already been serialized by the Union or ArrayType path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
PushPayLinkRequest.php and NullPropertyTest.php were hand-patched to fix PHPStan/PHPUnit failures; excluding them from Fern regeneration so the fixes aren't clobbered on the next generation run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.