fix: preserve published main document when saving draft#16643
Open
Rajib-Gupta wants to merge 1 commit into
Open
fix: preserve published main document when saving draft#16643Rajib-Gupta wants to merge 1 commit into
Rajib-Gupta wants to merge 1 commit into
Conversation
Rajib-Gupta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16633
fix: draft save no longer mutates published document when _status: 'published' is present
What?
Fixes draft save behavior so draft: true always creates or updates a draft version without mutating the existing published document, even when the incoming data includes _status: 'published'.
Why?
Previously, the draft-save path checked data._status !== 'published' to determine whether to treat an update as a draft. This meant that when the UI re-sent _status: 'published' alongside a draft save request, the published main record could be incorrectly mutated — or even flipped into draft state.
How?
Draft detection now relies solely on draft: true + hasDraftsEnabled(...), with no dependency on data._status.
Updated draft detection in collection update (packages/.../update.ts)
Updated draft detection in global update (packages/.../update.ts)
Added regression test coverage (int.spec.ts)
Fixes #