fix(next): restore modular dashboard widget drawer spacing#16687
Open
GermanJablo wants to merge 7 commits into
Open
fix(next): restore modular dashboard widget drawer spacing#16687GermanJablo wants to merge 7 commits into
GermanJablo wants to merge 7 commits into
Conversation
…onent colors Added padding to the widget and adjusted alignment for card content in the ModularDashboard. Updated background and text colors in the Private component to align with the new design specifications.
Move the align-items override from the dashboard scope to the global .card element. The Card React component is only used internally by CollectionCards, which is the only widget that renders into the modular dashboard, so scoping the fix to .modular-dashboard was functionally equivalent today but would silently regress for any third-party consumer of the exported <Card> component, which is part of the public API.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
GermanJablo
changed the base branch from
cursor/modular-dashboard-default-card
to
main
GermanJablo
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Member
|
@GermanJablo looks good, made a few changes:
It looks like the failing tests are flaky, lets see it CI passes 🤞 |
JessRynkar
approved these changes
May 20, 2026
Member
|
@GermanJablo looks like we have some real test failures, lets get those passing and then I can re-approve! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16685.
This fixes the widget edit drawer in the modular dashboard.
The drawer styling changed in #16620. From that PR, it looks like this was expected:
Drawerno longer adds padding to its content by default. Instead, simple drawer content should useDrawerContentContainer.The modular dashboard widget drawer was still putting the form fields directly inside
Drawer, so everything ended up too close to the edges. This PR wraps that form inDrawerContentContainer.I also added a small margin above the save button because it was stuck to the field above it.
I am less sure about the button width.
FormSubmitis full-width by default, but here it looked odd in a small drawer, so I scoped the override to this drawer only. Please let me know if this should follow a different v4 drawer/form pattern.There may be other drawers that still need similar updates after #16620. I kept this one limited to modular dashboard.
Before
After