fix(ui): preserve polymorphic upload bulk select relation#16695
Open
damnsamn wants to merge 1 commit into
Open
fix(ui): preserve polymorphic upload bulk select relation#16695damnsamn wants to merge 1 commit into
damnsamn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes polymorphic upload fields with
hasManyenabled when selecting existing documents via the list drawer checkbox flow.Previously, bulk-selecting documents from a non-first upload collection saved the selected IDs with the first configured
relationTocollection. For example, selecting documents fromuploads-2could save values asuploads-1relationships with IDs that do not exist inuploads-1.Why?
The single row-click selection path already receives the active row collection slug and saves the correct polymorphic relationship. The checkbox bulk-selection path only received selected IDs, so
UploadInputfell back to its initialactiveRelationTo, which is the first configured collection.This caused broken polymorphic upload values whenever the drawer collection dropdown was changed before using checkbox selection.
How?
onBulkSelect.relationTois preserved.Fixes #16696