fix: sanitize client upload file keys#16697
Open
aerin-png wants to merge 1 commit into
Open
Conversation
aerin-png
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16694
this makes client upload storage keys use the same filename sanitization behavior as upload filename generation.
before this, a filename like
My Photo...pngcould be saved in the db asMy Photo.png, while the storage key was still generated asMy Photo...png.added a regression test for
getFileKey.verified with:
npm exec --yes pnpm@10.33.2 -- vitest run packages/plugin-cloud-storage/src/utilities/getFileKey.spec.ts packages/payload/src/uploads/getSafeFilename.spec.ts