feat(ui): sticky page controls with flexbox layout#16701
Open
JarrodMFlesch wants to merge 14 commits into
Open
feat(ui): sticky page controls with flexbox layout#16701JarrodMFlesch wants to merge 14 commits into
JarrodMFlesch wants to merge 14 commits into
Conversation
- Add sticky positioning to PageControls with edge-to-edge styling - Use flexbox to push page controls to bottom of list view - Update PerPage to use PopupList.IconButtonGroup with active state - Add border styling to PerPage trigger button - Convert pagination separator color to --color-border token - Update GroupByHeader to use --text-heading-large typography - Convert SCSS files to CSS with @layer payload-default - Add perPageLabel translation key
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
- Update selectors for popup options from .per-page__button to .popup-button-list__button - Update text assertions from 'Per Page: X' to just 'X' in base button - Maintain Per page label checking via container
- Add hideNextDevTools helper to dismiss dev indicator that intercepts clicks - Call hideNextDevTools globally in ensureCompilationIsDone - Add force:true to pagination button clicks as additional safety - Fix goToPreviousPage URL wait for page 1 (no page param) - Update plugin-import-export per-page selector
Prevents preferences from persisting across sessions
- Add hideNextDevTools helper to dismiss dev indicator - Call hideNextDevTools in pagination helpers (goToNextPage, goToPreviousPage, setPerPageLimit) - Use exact regex matching in setPerPageLimit to avoid matching '15' when looking for '5' - Fix page-controls CSS: use justify-content: flex-end to push per-page to right when no paginator - Make pagination tests self-contained with page.goto() instead of page.reload()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Pagination component to v4 design with sticky page controls.
How to Test
Run the v4 test suite:
View collection list pagination: Navigate to
search-bar-testcollection list viewView versions pagination: Navigate to seeded
draft-versionsdoc → clickversionstab