fix: follow redirects when fetching uploaded files for MIME type detection#16708
Open
paulpopus wants to merge 1 commit into
Open
fix: follow redirects when fetching uploaded files for MIME type detection#16708paulpopus wants to merge 1 commit into
paulpopus wants to merge 1 commit into
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signedDownloadsenabled, thestaticHandlerreturns a302redirect to a pre-signed URL. Payload'saddDataAndFileToRequestutility calls this handler internally to fetch back the just-uploaded file for MIME type detection, but Node.jsfetchdoes not automatically follow redirects on aResponseobject returned from an internal handler call — resulting in an emptyArrayBufferand aDataView.getUint16()bounds error.staticHandler(if (signedDownloads && !clientUploadContext)) was meant to skip the redirect for internal upload processing, but fires anyway whenclientUploadContextisundefined(i.e. when no upload context is configured for the collection).addDataAndFileToRequestnow follows theLocationheader to retrieve the actual file bytes before processing.