fix(tanstack-start): show route-transition progress bar for full navigation#17382
Open
r1tsuu wants to merge 4 commits into
Open
fix(tanstack-start): show route-transition progress bar for full navigation#17382r1tsuu wants to merge 4 commits into
r1tsuu wants to merge 4 commits into
Conversation
…gation TanStack's router drives its own internal React transition, so the shared optimistic `isTransitioning` flag flipped back before the new view loaded — the top progress bar only flashed to 100% instead of tracking the navigation. Return the `router.navigate()` promise from the adapter's push/replace and let `startRouteTransition` await it, keeping the bar visible until navigation settles. No-op for Next.js, whose router methods return void.
r1tsuu
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 17, 2026 12:09
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
…vigations The 150ms anti-flicker delay swallowed the bar entirely for very fast client navigations (e.g. TanStack routing to already-loaded data), so it only flashed to 100% at the tail. Replace the delay with an immediate visible starting value plus a guaranteed minimum on-screen duration, so every navigation shows a real progress bar while slow navigations still track progress. Also skips the spurious 100% flash on initial mount. Enables the previously-flaky progress bar e2e test, whose flakiness this fixes, and drops its network-throttling workaround.
The router adapter's push/replace now return `Promise<void> | void`, so fire-and-forget call sites triggered no-floating-promises. Mark them with the void operator; call sites that need the navigation promise (Link, startRouteTransition) already return it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The top loading bar didn't track navigation in the TanStack Start admin (unlike Next.js). Two issues:
Why
isTransitioningflag flipped back to false before the destination view finished loading.Fix
push/replacenow return therouter.navigate()promise, andstartRouteTransitionreturns it from the transition so React keeps the transition — andisTransitioning— pending until navigation settles. No-op for Next.js (its router methods returnvoid).Tests
Enables the previously-flaky (
test.fixme) progress bar e2e test — the guaranteed minimum visible duration removes the timing dependency that made it flaky, so its network-throttling workaround is dropped.