PRE-3449: patch configs and upgrade PHP 7.4 - #20
Merged
adumont-payplug merged 1 commit intoJun 29, 2026
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
adumont-payplug
force-pushed
the
feature/PRE-3449_patching_configurations
branch
2 times, most recently
from
June 26, 2026 11:22
245d21b to
da06ba1
Compare
There was a problem hiding this comment.
Pull request overview
This PR rebrands the library from PayPlugPluginCore to PayPlugPluginMcp, upgrades the development/runtime target to PHP 7.4, and refreshes the project’s tooling/CI configuration accordingly.
Changes:
- Renamed namespaces/autoloading from
PayPlugPluginCore\toPayPlugPluginMcp\acrosssrc/andtests/. - Upgraded PHP/tooling baseline (Docker PHP 7.4, Composer PHP constraint, PHPUnit/PHPStan/PHP-CS-Fixer/CaptainHook) and raised PHPStan level.
- Updated CI/release workflows and local hooks/configs; adjusted refund flow to validate resource type via
instanceof Payplug\Resource\Payment.
Reviewed changes
Copilot reviewed 46 out of 48 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Units/Gateways/Refund/RefundGateway/refundGatewayBase.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Units/Gateways/Refund/RefundGateway/formatRefundAttributesTest.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Units/Gateways/PaymentGateway.php | Update test namespace and gateway class resolution namespace. |
| tests/Units/Gateways/Payment/StandardPaymentGateway/standardPaymentGatewayBase.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Units/Gateways/Payment/StandardPaymentGateway/formatPaymentAttributesTest.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Units/Actions/PaymentAction/refundActionTest.php | Update test namespace/imports; add PHPStan suppression tag. |
| tests/Units/Actions/PaymentAction/paymentActionBase.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Units/Actions/PaymentAction/createActionTest.php | Update test namespace/imports to PayPlugPluginMcp. |
| tests/Traits/TestingTools.php | Update trait namespace and mock class resolution namespace. |
| tests/Traits/FormatDataProvider.php | Update trait namespace to PayPlugPluginMcp. |
| tests/Mock/RefundOutputDTOMock.php | Update mock namespace/imports to PayPlugPluginMcp. |
| tests/Mock/RefundInputDTOMock.php | Update mock namespace/imports to PayPlugPluginMcp. |
| tests/Mock/PaymentOutputDTOMock.php | Update mock namespace/imports to PayPlugPluginMcp. |
| tests/Mock/PaymentMock.php | Update mock namespace to PayPlugPluginMcp. |
| tests/Mock/PaymentInputDTOMock.php | Update mock namespace/imports to PayPlugPluginMcp. |
| tests/Integration/PaymentAction/refundActionTest.php | Update integration test namespace/imports to PayPlugPluginMcp. |
| tests/Integration/PaymentAction/createActionTest.php | Update integration test namespace/imports to PayPlugPluginMcp. |
| stubs/PayplugPayment.stub | Remove Payment stub (likely no longer needed with updated tooling). |
| src/Validators/RefundValidator.php | Namespace update; qualify sprintf calls. |
| src/Validators/PaymentResourceValidator.php | Namespace update; qualify sprintf calls. |
| src/Utilities/Services/Api.php | Namespace update to PayPlugPluginMcp. |
| src/Models/Entities/RefundOutputDTO.php | Namespace update to PayPlugPluginMcp. |
| src/Models/Entities/RefundInputDTO.php | Namespace update to PayPlugPluginMcp. |
| src/Models/Entities/PaymentOutputDTO.php | Namespace update to PayPlugPluginMcp. |
| src/Models/Entities/PaymentInputDTO.php | Namespace update to PayPlugPluginMcp. |
| src/Gateways/RefundGateway.php | Namespace/import update to PayPlugPluginMcp. |
| src/Gateways/PaymentGatewayManager.php | Namespace update; update class resolution namespace. |
| src/Gateways/Payment/StandardPaymentGateway.php | Namespace/import update to PayPlugPluginMcp. |
| src/Gateways/Payment/EmailLinkPaymentGateway.php | Namespace/import update to PayPlugPluginMcp. |
| src/Gateways/AbstractPaymentGateway.php | Namespace/import update to PayPlugPluginMcp. |
| src/Actions/PaymentAction.php | Namespace update; add Payment type check for refund resource. |
| scripts/generate-release-composer.php | Remove legacy release composer generation script. |
| scripts/check-branch-name.sh | Remove legacy branch-name check script. |
| Readme.md | Update documented PHP requirement (currently inconsistent with Composer/Docker). |
| phpstan.neon | Increase PHPStan level to 8. |
| Makefile | Update debug env vars and remove release helpers; targets list now needs alignment. |
| Dockerfile | Upgrade base image to PHP 7.4 and Xdebug 3-style config. |
| composer.lock | Lock upgraded toolchain/dev dependencies and PHP platform to ^7.4. |
| composer.json | Rename package, raise PHP constraint to ^7.4, update dev tool versions, update autoload namespaces. |
| captainhook.json | Update commit-msg regex and switch to EnsureNaming for branch checks. |
| .php-cs-fixer.dist.php | Update rules for php-cs-fixer v3 (e.g., trailing comma rule name). |
| .gitignore | Add docs/ ignore entry. |
| .github/workflows/release.yml | Add tag-driven GitHub release workflow. |
| .github/workflows/pre-release.yml | Add RC tag-driven quality + GitHub RC release workflow. |
| .github/workflows/ci.yml | Simplify CI to PR-driven quality + SonarCloud. |
| .github/workflows/auto-tag-rc.yml | Add auto-tag RC workflow for release branches. |
| .github/PULL_REQUEST_TEMPLATE.md | Update PR template to new checklist-driven format. |
| .github/copilot-instructions.md | Add repository-specific Copilot review guidance (needs alignment with new PHP baseline). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adumont-payplug
force-pushed
the
feature/PRE-3449_patching_configurations
branch
from
June 26, 2026 12:59
da06ba1 to
910d53c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 46 out of 48 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
tests/Units/Gateways/Payment/StandardPaymentGateway/formatPaymentAttributesTest.php:11
- This test uses the PHPUnit group name "unit" (singular), while other unit tests use "units" and the Makefile target
test-unit-unitsruns--group units. As a result, this test will be skipped when running that target.
ilajili
reviewed
Jun 26, 2026
adumont-payplug
force-pushed
the
feature/PRE-3449_patching_configurations
branch
from
June 26, 2026 13:40
910d53c to
8196dac
Compare
ilajili
approved these changes
Jun 26, 2026
ilajili
approved these changes
Jun 26, 2026
jhoaraupp
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Ticket: PRE-3449
Type of Change
[ ] 🐛 Bug fix
[ ] ✨ New feature
[x] 💥 Breaking change
[ ] ♻️ Refactor
[ ] 🔧 Configuration / CI
[ ] 🚀 Release (
release/*branch targetingmaster)[ ] 📦 Dependency update
[ ] 🔒 Security fix
[ ] 📝 Documentation update
✅ Quality Checklist
Local Environment & Hooks
(PRE|SMP)-XXXX: descriptionpattern.phpstan.neon/.php-cs-fixer.php) were generated successfully from.disttemplates.Testing & Code Quality
composer cs:fix).vendor/bin/phpstan).CI/CD Deployment Context
release/*branch, I am targeting the correct base branch to allow the automatedapply-releaseversion bumping job to run.Screenshots (if applicable)
Notes for Reviewer