Skip to content

PRE-3449: patch configs and upgrade PHP 7.4 - #20

Merged
adumont-payplug merged 1 commit into
developfrom
feature/PRE-3449_patching_configurations
Jun 29, 2026
Merged

PRE-3449: patch configs and upgrade PHP 7.4#20
adumont-payplug merged 1 commit into
developfrom
feature/PRE-3449_patching_configurations

Conversation

@adumont-payplug

@adumont-payplug adumont-payplug commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Description

  • upgrading to PHP 7.4
  • updating Dockerfile and configurations
  • Updating CI
  • Rebranding the Project from PPC to MCP

Related Issue

Ticket: PRE-3449

Type of Change

[ ] 🐛 Bug fix
[ ] ✨ New feature
[x] 💥 Breaking change
[ ] ♻️ Refactor
[ ] 🔧 Configuration / CI
[ ] 🚀 Release (release/* branch targeting master)
[ ] 📦 Dependency update
[ ] 🔒 Security fix
[ ] 📝 Documentation update


✅ Quality Checklist

Local Environment & Hooks

  • Local Git hooks (CaptainHook) are installed and executed cleanly.
  • Commit messages strictly follow the (PRE|SMP)-XXXX: description pattern.
  • Core configuration files (phpstan.neon / .php-cs-fixer.php) were generated successfully from .dist templates.

Testing & Code Quality

  • Coding style rules have been applied locally (composer cs:fix).
  • Static analysis checks pass with no new regressions (vendor/bin/phpstan).
  • I have added/updated unit or integration tests if applicable.
  • I have verified these changes locally on a native PrestaShop environment.

CI/CD Deployment Context

  • The CI pipeline passes fully on GitHub.
  • For Release Branches: If this is a release/* branch, I am targeting the correct base branch to allow the automated apply-release version bumping job to run.

Screenshots (if applicable)

Notes for Reviewer

@adumont-payplug adumont-payplug self-assigned this Jun 26, 2026
@wiz-14d684d7a6

wiz-14d684d7a6 Bot commented Jun 26, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 3 Medium
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total 3 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@adumont-payplug
adumont-payplug force-pushed the feature/PRE-3449_patching_configurations branch 2 times, most recently from 245d21b to da06ba1 Compare June 26, 2026 11:22
@adumont-payplug
adumont-payplug requested a review from Copilot June 26, 2026 11:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rebrands the library from PayPlugPluginCore to PayPlugPluginMcp, upgrades the development/runtime target to PHP 7.4, and refreshes the project’s tooling/CI configuration accordingly.

Changes:

  • Renamed namespaces/autoloading from PayPlugPluginCore\ to PayPlugPluginMcp\ across src/ and tests/.
  • Upgraded PHP/tooling baseline (Docker PHP 7.4, Composer PHP constraint, PHPUnit/PHPStan/PHP-CS-Fixer/CaptainHook) and raised PHPStan level.
  • Updated CI/release workflows and local hooks/configs; adjusted refund flow to validate resource type via instanceof Payplug\Resource\Payment.

Reviewed changes

Copilot reviewed 46 out of 48 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
tests/Units/Gateways/Refund/RefundGateway/refundGatewayBase.php Update test namespace/imports to PayPlugPluginMcp.
tests/Units/Gateways/Refund/RefundGateway/formatRefundAttributesTest.php Update test namespace/imports to PayPlugPluginMcp.
tests/Units/Gateways/PaymentGateway.php Update test namespace and gateway class resolution namespace.
tests/Units/Gateways/Payment/StandardPaymentGateway/standardPaymentGatewayBase.php Update test namespace/imports to PayPlugPluginMcp.
tests/Units/Gateways/Payment/StandardPaymentGateway/formatPaymentAttributesTest.php Update test namespace/imports to PayPlugPluginMcp.
tests/Units/Actions/PaymentAction/refundActionTest.php Update test namespace/imports; add PHPStan suppression tag.
tests/Units/Actions/PaymentAction/paymentActionBase.php Update test namespace/imports to PayPlugPluginMcp.
tests/Units/Actions/PaymentAction/createActionTest.php Update test namespace/imports to PayPlugPluginMcp.
tests/Traits/TestingTools.php Update trait namespace and mock class resolution namespace.
tests/Traits/FormatDataProvider.php Update trait namespace to PayPlugPluginMcp.
tests/Mock/RefundOutputDTOMock.php Update mock namespace/imports to PayPlugPluginMcp.
tests/Mock/RefundInputDTOMock.php Update mock namespace/imports to PayPlugPluginMcp.
tests/Mock/PaymentOutputDTOMock.php Update mock namespace/imports to PayPlugPluginMcp.
tests/Mock/PaymentMock.php Update mock namespace to PayPlugPluginMcp.
tests/Mock/PaymentInputDTOMock.php Update mock namespace/imports to PayPlugPluginMcp.
tests/Integration/PaymentAction/refundActionTest.php Update integration test namespace/imports to PayPlugPluginMcp.
tests/Integration/PaymentAction/createActionTest.php Update integration test namespace/imports to PayPlugPluginMcp.
stubs/PayplugPayment.stub Remove Payment stub (likely no longer needed with updated tooling).
src/Validators/RefundValidator.php Namespace update; qualify sprintf calls.
src/Validators/PaymentResourceValidator.php Namespace update; qualify sprintf calls.
src/Utilities/Services/Api.php Namespace update to PayPlugPluginMcp.
src/Models/Entities/RefundOutputDTO.php Namespace update to PayPlugPluginMcp.
src/Models/Entities/RefundInputDTO.php Namespace update to PayPlugPluginMcp.
src/Models/Entities/PaymentOutputDTO.php Namespace update to PayPlugPluginMcp.
src/Models/Entities/PaymentInputDTO.php Namespace update to PayPlugPluginMcp.
src/Gateways/RefundGateway.php Namespace/import update to PayPlugPluginMcp.
src/Gateways/PaymentGatewayManager.php Namespace update; update class resolution namespace.
src/Gateways/Payment/StandardPaymentGateway.php Namespace/import update to PayPlugPluginMcp.
src/Gateways/Payment/EmailLinkPaymentGateway.php Namespace/import update to PayPlugPluginMcp.
src/Gateways/AbstractPaymentGateway.php Namespace/import update to PayPlugPluginMcp.
src/Actions/PaymentAction.php Namespace update; add Payment type check for refund resource.
scripts/generate-release-composer.php Remove legacy release composer generation script.
scripts/check-branch-name.sh Remove legacy branch-name check script.
Readme.md Update documented PHP requirement (currently inconsistent with Composer/Docker).
phpstan.neon Increase PHPStan level to 8.
Makefile Update debug env vars and remove release helpers; targets list now needs alignment.
Dockerfile Upgrade base image to PHP 7.4 and Xdebug 3-style config.
composer.lock Lock upgraded toolchain/dev dependencies and PHP platform to ^7.4.
composer.json Rename package, raise PHP constraint to ^7.4, update dev tool versions, update autoload namespaces.
captainhook.json Update commit-msg regex and switch to EnsureNaming for branch checks.
.php-cs-fixer.dist.php Update rules for php-cs-fixer v3 (e.g., trailing comma rule name).
.gitignore Add docs/ ignore entry.
.github/workflows/release.yml Add tag-driven GitHub release workflow.
.github/workflows/pre-release.yml Add RC tag-driven quality + GitHub RC release workflow.
.github/workflows/ci.yml Simplify CI to PR-driven quality + SonarCloud.
.github/workflows/auto-tag-rc.yml Add auto-tag RC workflow for release branches.
.github/PULL_REQUEST_TEMPLATE.md Update PR template to new checklist-driven format.
.github/copilot-instructions.md Add repository-specific Copilot review guidance (needs alignment with new PHP baseline).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Readme.md
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread Dockerfile Outdated
Comment thread captainhook.json
Comment thread .github/workflows/pre-release.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/copilot-instructions.md
Comment thread .github/copilot-instructions.md Outdated
Comment thread .github/copilot-instructions.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 46 out of 48 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

tests/Units/Gateways/Payment/StandardPaymentGateway/formatPaymentAttributesTest.php:11

  • This test uses the PHPUnit group name "unit" (singular), while other unit tests use "units" and the Makefile target test-unit-units runs --group units. As a result, this test will be skipped when running that target.

Comment thread Readme.md
Comment thread captainhook.json
Comment thread Readme.md Outdated
@adumont-payplug
adumont-payplug force-pushed the feature/PRE-3449_patching_configurations branch from 910d53c to 8196dac Compare June 26, 2026 13:40
@adumont-payplug
adumont-payplug merged commit 663bcf0 into develop Jun 29, 2026
8 checks passed
@adumont-payplug
adumont-payplug deleted the feature/PRE-3449_patching_configurations branch June 29, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants