Repository navigation
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
madesst
marked this pull request as ready for review
October 22, 2026 11:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 309 309
Lines 39178 39176 -2
=========================================
- Hits 39178 39176 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cover the retained local/remote WaitForIndexing API directly after removing its use from component lookup, and verify an untracked context is not considered indexing. Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid waiting for another document's completed reference index when looking up an external component. The target's parsed YAML is sufficient for the lookup and is already available through
GetContentAsYAMLNode.lookupRolodexcan be called while two files are being indexed concurrently. If each references the other, waiting on the other file'sindexingCompletechannel can deadlock even though the referenced schema graph is finite. Keep using the target index when it is already available; otherwise resolve the component from its parsed content.Add a regression with a loaded target file whose index is pending. It proves that component lookup completes without waiting for indexing; the test fails on unchanged main and passes with this change.
Validation
GOWORK=off go test -p=2 ./... -timeout=180sGOWORK=off go test -p=2 ./index ./bundler -count=1 -timeout=180sGOWORK=off go test -race -p=2 ./index -run '^TestLookupRolodexDoesNotWaitForTargetIndex$' -count=1 -timeout=60sGOWORK=off go vet ./index ./bundlergofmtandgit diff --checkThe companion Vacuum fragment-policy fix is daveshanley/vacuum#1007. With both fixes applied, the consumer's complete OpenAPI/JSON Schema lint, negative audience-boundary/traversal/symlink fixtures, and composed public-webhook bundling pass without suppressing reference errors.
Made with Codex