OCTO-11477#374
Merged
Merged
Conversation
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
🟡 PR Compliance ReviewRisk Level: MEDIUM
REVIEW REQUIRED - Address issues before merging Full report available in workflow artifacts |
dianadersedan
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elements that pass the get_text().strip() filter but yield zero parsed nodes
Root Cause
_convert_p_tag_to_caption() explicitly returns None when its internal node list is empty after parsing (e.g., content that passes the text-presence check but fails the indentation-stripping regex).
The list comprehension in _convert_div_to_caption_list() did not filter these None values before constructing the CaptionList.
The fix wraps the existing generator in an outer comprehension that filters out None results.
Tests added:
elements do not produce None entries in CaptionList
is empty — merge_concurrent_captions() does not crash
No re-ingestion needed — production only accepts SCC inputs; DFXP reader path is not exercised