chore: sync main → dev#2064
Conversation
Users with Bridge KYC status 'incomplete' (needs TOS acceptance) were shown a dead-end 'Your verification is under review' modal because AddWithdrawCountriesList checked isUserBridgeKycUnderReview before consulting the transfer readiness gate. The gate correctly identifies TOS as the blocker via rails metadata, but was never reached. Changes: - Split isBridgeUnderReview into isBridgeUnderReview (genuinely under review) and isBridgeIncomplete (user needs to act) - AddWithdrawCountriesList now checks the gate first — TOS modal opens for incomplete users, 'under review' only for genuinely reviewing - Added BridgeTosStep and InitiateKycModal to the country list view - Updated useBridgeTransferReadiness to skip enrollment for incomplete - Updated LimitsPageView and useHomeCarouselCTAs for the new flag
- Extract checkBridgeGate() helper — gate-check + under-review block was duplicated in handleAddMethodClick and handleWithdrawMethodClick - Hoist InitiateKycModal, BridgeTosStep, SumsubKycModals into sharedModals fragment — rendered once instead of duplicated in form and list views - Fix BridgeTosStep onComplete in list view: was a no-op (just hideTos). Now stores the interrupted method click in a ref and replays it after TOS acceptance. Form view falls back to formRef.current?.handleSubmit() as before.
- handleFormSubmit now checks isUserBridgeKycUnderReview after the gate check — prevents erroneously initiating sumsub for users whose bridge KYC is genuinely under review (reachable via deep-link or back nav) - add explicit regression test for the main bug scenario: bridge incomplete + tos needed → gate returns accept_tos
fix: check transfer readiness gate before 'under review' modal
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThe PR refines bridge KYC status tracking by splitting ChangesBridge KYC State Refinement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Code-analysis diffPainscore total: 5716.29 → 5718.73 (+2.44) 🆕 New findings (27)
…and 7 more. ✅ Resolved (27)
…and 7 more. 📈 Painscore deltas (top movers)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Summary