Skip to content

chore(kyc): add bridge-uplift to KycActionType#2220

Open
jjramirezn wants to merge 2 commits into
devfrom
chore/bridge-uplift-action-type
Open

chore(kyc): add bridge-uplift to KycActionType#2220
jjramirezn wants to merge 2 commits into
devfrom
chore/bridge-uplift-action-type

Conversation

@jjramirezn

Copy link
Copy Markdown
Contributor

Companion to peanutprotocol/peanut-api-ts#1013 — the BE now returns actionType: 'bridge-uplift' (with an SDK token) when an EU/NA cross-region tap comes from an applicant that never completed bridge-requirements. The hook already handles any token-bearing actionType generically (token → SDK opens, setIsActionFlow), so this is type-only with no deploy coupling.

🤖 Generated with Claude Code

peanut-api-ts#1013 returns actionType 'bridge-uplift' (with an SDK token)
when an EU/NA cross-region tap comes from an applicant that never completed
bridge-requirements. Runtime already handles any token-bearing actionType
generically; this keeps the union honest.
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Jun 12, 2026 1:30pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 807e4549-7994-4297-a9fb-fd8db910f6b4

📥 Commits

Reviewing files that changed from the base of the PR and between 3923b8f and 29cc5af.

📒 Files selected for processing (1)
  • src/app/actions/types/sumsub.types.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app/actions/types/sumsub.types.ts

Walkthrough

Adds a new 'bridge-uplift' member to the exported KycActionType union and documents a cross-region Bridge "tap" flow where the backend returns an applicant-action token that the SDK uses to collect Bridge data deltas (email and questionnaire).

Changes

KycActionType Extension

Layer / File(s) Summary
KycActionType union extension and usage
src/app/actions/types/sumsub.types.ts
KycActionType union extended with 'bridge-uplift'; inline comments describe the cross-region Bridge token/delta collection flow; InitiateSumsubKycResponse.actionType now accepts the new union value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

enhancement

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding 'bridge-uplift' to the KycActionType union type.
Description check ✅ Passed The description is directly related to the changeset, explaining the context and purpose of adding the new 'bridge-uplift' action type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 5818.17 → 5818.44 (+0.27)
Findings: 0 net (+0 new, -0 resolved)

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 1429 ran, 0 failed, 0 skipped, 19.6s

📊 Coverage (unit)

metric %
statements 51.4%
branches 33.6%
functions 39.3%
lines 51.4%
⏱ 10 slowest test cases
time test
0.3s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in updateUserById body
0.3s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every stamp stays within canvas at any count
0.3s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in updateUserById
0.2s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid 9-digit US account
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle maximum length (17 digits) US account
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid US account with spaces 2
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid ETH address in lowercase
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid ETH address with surrounding spaces
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle invalid ETH address (missing 0x prefix)
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid US account with spaces
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant