hotfix(add-money): revert bank-step shortcut (AR/BR shown Euro selector)#2278
Merged
Conversation
…he Bridge EUR flow #2276 made country-click go straight to /add-money/[country]/bank, but that is the Bridge (EUR/SEPA) bank page. Argentina/Brazil bank deposits route through Manteca (Pix/CBU), which the per-country method picker on /add-money/[country] was correctly resolving. Skipping the picker forced every country into the Bridge bank page, so AR/BR users saw a Euro selector. Revert to addMoneyCountryUrl (the method picker). The double-selection #2276 tried to remove is a separate, lower-priority UX nit; a correct fix must be per-country (skip only single-bank EU/NA countries), not a blanket shortcut.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
WalkthroughAdd-money country selection now navigates to the country root route instead of the bank step. The bank URL helper was removed, and the related route tests were updated to match the new path. ChangesAdd Money country routing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Contributor
Code-analysis diffPainscore total: 5745.45 → 5745.66 (+0.21) 🆕 New findings (4)
✅ Resolved (4)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Prod regression
#2276 (merged to dev, now on
mainvia release #2245) made add-money country-click go straight to/add-money/[country]/bank. That route is the Bridge (EUR/SEPA) bank page. Argentina/Brazil bank deposits go through Manteca (Pix/CBU), which the per-country method picker on/add-money/[country]was correctly resolving.Skipping that picker forced every country into the Bridge bank page → AR/BR users see a Euro selector when adding money.
Fix
Revert
handleCountryClicktoaddMoneyCountryUrl(the method picker) and remove theaddMoneyBankUrlhelper + its tests. Restores correct per-country routing.Scope
Pure revert of #2276's behavior change — these 4 files return to their pre-#2276 state. The double-selection UX nit #2276 tried to fix is separate/lower-priority; a correct fix must be per-country (skip the picker only for single-bank EU/NA countries), not a blanket shortcut.
Tests
native-routes+add-money-statesrestored to pre-#2276 assertions; pass. (Pre-existing local-only EVM-deposit test failure is unrelated — CI passes it.)Follow-up
devalso carries #2276 — the post-releasemain→devback-merge will carry this revert, or cherry-pick if dev ships first.