feat(card): tweak win + rejection share captions#2286
Conversation
Punchier rejection lines (drop the trailing justifications), add a 'bouncer now??' jab and two Devconnect-callback rejections, plus an Argentina/global callback in the win pool — all keep the @joinpeanut tag.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated the share-asset caption pools for rejection and win states. Several rejection captions were rewritten or shortened, two new rejection captions were added, and two new win captions were added. The caption selection logic was unchanged. ChangesShare asset caption pools
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Card/share-asset/rejectionCaptions.ts`:
- Around line 35-36: The new Devconnect caption contains a visible typo in the
shared X intent text. Update the second string in rejectionCaptions so it uses
the correct spelling of “remember” (not “rember”), keeping the rest of the
caption unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2daed7b1-b9a5-4a49-bc65-ef80694f7ce3
📒 Files selected for processing (2)
src/components/Card/share-asset/rejectionCaptions.tssrc/components/Card/share-asset/winCaptions.ts
| "remember @joinpeanut from devconnect?? they've rejected me from their beta programme omg", | ||
| "rember @joinpeanut from devconnect?? seems they're back but also they don't want users ??? WHAT?", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the typo in the new Devconnect caption.
Line 36 says rember, and this string is passed straight through to the X intent text, so the typo becomes user-visible in shared posts.
Suggested fix
- "rember `@joinpeanut` from devconnect?? seems they're back but also they don't want users ??? WHAT?",
+ "remember `@joinpeanut` from devconnect?? seems they're back but also they don't want users ??? WHAT?",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "remember @joinpeanut from devconnect?? they've rejected me from their beta programme omg", | |
| "rember @joinpeanut from devconnect?? seems they're back but also they don't want users ??? WHAT?", | |
| "remember `@joinpeanut` from devconnect?? they've rejected me from their beta programme omg", | |
| "remember `@joinpeanut` from devconnect?? seems they're back but also they don't want users ??? WHAT?", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/Card/share-asset/rejectionCaptions.ts` around lines 35 - 36,
The new Devconnect caption contains a visible typo in the shared X intent text.
Update the second string in rejectionCaptions so it uses the correct spelling of
“remember” (not “rember”), keeping the rest of the caption unchanged.
0xkkonrad
merged commit 5afc214
into
feat/card-share-sticker-collage
1 participant
Copy-only follow-up to #2274, stacked on
feat/card-share-sticker-collage(retarget todevonce #2274 merges).Touches only the two caption pools — no logic, no asset changes. All captions keep the
@joinpeanuttag (the file invariant).Rejection pool (
rejectionCaptions.ts)…the door policy is insane. i WILL be back.→…the door policy is insane.officially rejected by @joinpeanut. honestly an honor 🥜🚫→officially rejected by @joinpeanut.…guess i'll fix my whole life and come back→…guess i'll fix my whole lifeturned away from @joinpeanut 💀 most exclusive door in crypto fr→turned away from @joinpeanut 💀@joinpeanut has a bouncer now??remember @joinpeanut from devconnect?? they've rejected me from their beta programme omgrember @joinpeanut from devconnect?? seems they're back but also they don't want users ??? WHAT?(rembertypo intentional)Win pool (
winCaptions.ts)@joinpeanutconvention):remember @joinpeanut from argentina? they're global now. just got into their closed betasaw @joinpeanut in argentina. they went global — and i'm in the closed beta.Checks
pnpm prettier --check✓ · typecheck (no new errors) ✓ ·jest src/components/Card/share-asset24/24 ✓