fix(card): bring launch CTA in line with the activation CTAs#2299
Merged
Conversation
Launch-day design review (Konrad): the banner was off-system — pink (pink=clickable in Peanut), a black drop-shadow that misaligned the bounding box, and a black CTA used nowhere else. Now a white card, no drop shadow, standard purple primary CTA — matching the other activation CTAs. Copy + /shhhhh routing + gating unchanged; cosmetic only.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesCardLaunchCTABanner styling
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Contributor
Code-analysis diffPainscore total: 5846.18 → 5846.47 (+0.29) |
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Border was border-2 (2px) vs the activation CTAs' 1px (Global Card = border border-black); drop to 1px. Title shhh → shhhh (one more h).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bring the in-app card launch CTA (
CardLaunchCTABanner) in line with the other activation CTAs, per Konrad's launch-day design review.3 changes (cosmetic only):
bg-primary-1→bg-white(pink reads as "clickable" everywhere else in Peanut; this is a card)shadow-[4px_4px_0_#000]drop shadow (black-on-black, and it misaligned the bounding box)variant="dark"→variant="purple"(the standard primary CTA; the black CTA exists nowhere else)Copy ("shhh" / "Tap to find out if you're in" / "Try the door →"), the
/shhhhhrouting, and all gating are unchanged.Why hotfix to
mainThe launch (#2298 + api #1079) is already merged and deployed; this is a cosmetic follow-up to match the design system without waiting for the next dev→main cycle.
Follow-up
Needs back-merging to
devafter this merges (standard release-flow) so the next release doesn't reintroduce the old styling.Risk
Single file, 5 lines, no logic/routing/gating change. Prettier confirmed class order unchanged.