Skip to content

fix(card): address CodeRabbit on the terminal waitlist screen#2304

Merged
Hugo0 merged 1 commit into
mainfrom
hotfix/rejection-screen-cr-fixes
Jun 29, 2026
Merged

fix(card): address CodeRabbit on the terminal waitlist screen#2304
Hugo0 merged 1 commit into
mainfrom
hotfix/rejection-screen-cr-fixes

Conversation

@Hugo0

@Hugo0 Hugo0 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #2303 (merged). Resolves the 3 CodeRabbit findings:

  • Major: join-CTA flicker — add a locallyJoined override (set only on a confirmed join, success-only so a failed appeal-join doesn't falsely flip) so the CTA swaps to 'on the list' immediately, not after the refetch.
  • Minor: CARD_WAITLIST_VIEWED now sends the real already_joined (screen can mount already-joined).
  • Minor: handleAppeal clears stale joinError so 'Failed to join' can't show next to 'You're on the list'.

Single file (CardRejectionScreen.tsx). eslint clean, typecheck clean, prettier clean. Hotfix off main; needs back-merge to dev.

1) Local 'locallyJoined' override (set only on a confirmed join) so the 'Join anyway' CTA swaps to the on-the-list state immediately instead of flickering back until the /card refetch resolves. 2) CARD_WAITLIST_VIEWED now reports the real already_joined (the screen can mount already-joined). 3) handleAppeal clears any stale joinError so 'Failed to join' can't render alongside 'You're on the list'.
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
peanut-wallet Ready Ready Preview, Comment Jun 29, 2026 1:47pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 460ef100-f2ee-4132-af5e-1c38b55eccb4

📥 Commits

Reviewing files that changed from the base of the PR and between 622968b and eb6646b.

📒 Files selected for processing (1)
  • src/components/Card/CardRejectionScreen.tsx

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 5842.93 → 5843.49 (+0.56)
Findings: 0 net (+5 new, -5 resolved)

🆕 New findings (5)

  • medium high-mdd — src/components/Card/CardRejectionScreen.tsx:49 — CardRejectionScreen: MDD 37.2 (uses across many lines from declarations)
  • medium complexity — src/components/Card/CardRejectionScreen.tsx — CC 21, MI 57.4, SLOC 98
  • low high-dlt — src/components/Card/CardRejectionScreen.tsx:49 — CardRejectionScreen: DLT 23 (calls 23 distinct functions — high context load)
  • low high-dlt — src/components/Card/CardRejectionScreen.tsx:95 — handleAppeal: DLT 17 (calls 17 distinct functions — high context load)
  • low high-mdd — src/components/Card/CardRejectionScreen.tsx:95 — handleAppeal: MDD 14.1 (uses across many lines from declarations)

✅ Resolved (5)

  • src/components/Card/CardRejectionScreen.tsx:49 — CardRejectionScreen: MDD 31.4 (uses across many lines from declarations)
  • src/components/Card/CardRejectionScreen.tsx — CC 20, MI 58.21, SLOC 92
  • src/components/Card/CardRejectionScreen.tsx:49 — CardRejectionScreen: DLT 22 (calls 22 distinct functions — high context load)
  • src/components/Card/CardRejectionScreen.tsx:88 — handleAppeal: DLT 15 (calls 15 distinct functions — high context load)
  • src/components/Card/CardRejectionScreen.tsx:88 — handleAppeal: MDD 13.9 (uses across many lines from declarations)

📈 Painscore deltas (top movers)

File Before After Δ
src/components/Card/CardRejectionScreen.tsx 8.9 9.5 +0.6

@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • unit: 1601 ran, 0 failed, 0 skipped, 24.9s

📊 Coverage (unit)

metric %
statements 54.4%
branches 36.9%
functions 42.0%
lines 54.3%
⏱ 10 slowest test cases
time test
3.7s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
0.5s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › every sticker stays within canvas at any count
0.4s src/app/actions/__tests__/api-headers-extended.test.ts › should not include apiKey in updateUserById body
0.3s src/app/actions/__tests__/api-headers.test.ts › should include Content-Type in updateUserById
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid 9-digit US account
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid ETH address
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle invalid ETH address (missing 0x prefix)
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid US account with spaces
0.1s src/components/Global/GeneralRecipientInput/__tests__/GeneralRecipientInput.test.tsx › should handle valid ETH address in lowercase
0.1s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Manteca PIX form ready shows merchant card + amount input + pay button
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@Hugo0 Hugo0 merged commit 55f7677 into main Jun 29, 2026
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant