fix(card): space in physical-waitlist position copy ("#16on" → "#16 on")#2311
Merged
Conversation
…e literal
The "You are #N on the list" copy ships to prod AND staging as
`["You are #", position, "on the list…"]` — no leading space — so it
renders "You are #16on the list". The source has a same-line space
(prettier enforces it and reverts `{' '}`), and a clean next-swc compile
keeps the space, so the live no-space bundle is a stale build artifact.
A template literal bakes the space into one JS string (immune to JSX
whitespace handling) and changes the module so the stale artifact can't
be reused. Matches the existing pattern in JoinWaitlistPage.tsx.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single line in ChangesWaitlist Message Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
Contributor
Code-analysis diffPainscore total: 5851.3 → 5851.46 (+0.16) 🆕 New findings (2)
✅ Resolved (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The physical-card waitlist "joined" state renders "You are #16on the list" (missing space) in production. Confirmed live on both
peanut.meandstaging.peanut.me— the shipped bundle is["You are #", position, "on the list…"]with no leading space.The source looks correct (
#{data.position} on the list, space on the same line), and:{' '}back to a literal space), and@next/swccompile of the current source keeps the space.So the live no-space output is a stale build artifact, not a source bug. This fix sidesteps the whole class of problem by moving the sentence into a template literal — the space becomes a literal character inside one JS string, immune to JSX whitespace handling, and the module change guarantees a fresh compile (no stale-artifact reuse). Matches the existing template-literal pattern in
JoinWaitlistPage.tsx.Risk
Minimal. One-line, copy-only change in
PhysicalCardScreen.tsx; no logic, props, imports, or types touched.data.positionis interpolated identically;'→ literal'inside the template string renders the same apostrophe.QA
Load
/card/physicalas a user already on the physical-card waitlist → the joined state should read "You are #16 on the list." (space present). Verifiable on staging once back-merged todev.Back-merge
Staging shows the same bug, so after this lands on
mainit should be back-merged todev.