fix: preserve double underscores in attribute names#174
Open
tompassarelli wants to merge 1 commit intopelme:mainfrom
Open
fix: preserve double underscores in attribute names#174tompassarelli wants to merge 1 commit intopelme:mainfrom
tompassarelli wants to merge 1 commit intopelme:mainfrom
Conversation
Replace blanket replace("_", "-") with a sentinel-based approach that
preserves __ in attribute names. This fixes compatibility with frameworks
like Datastar that use __ as a modifier delimiter (e.g.
data-on:click__debounce.300ms, data-on:submit__prevent).
Contributor
|
There is the attribute helper in the datastar sdk which works nicely with htpy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_python_to_html_name()replaces all underscores with hyphens vianame.replace("_", "-"). This makes it impossible to express attribute names containing literal double underscores (__) through kwargs.Frameworks like Datastar use
__as a modifier delimiter in attribute names (e.g.data-on:click__debounce.300ms,data-on:submit__prevent). Currently these render incorrectly asdata-on:click--debounce.300ms.Users can work around this by passing a positional dict instead of kwargs, but this is surprising and undocumented.
Fix
Replace the blanket
replace("_", "-")with a sentinel-based approach that preserves__:Single underscores still convert to hyphens (existing behavior). Double underscores pass through unchanged.
Test
Added
test_double_underscore_preservedverifyingdiv(data_on_click__window="alert()")renders as<div data-on-click__window="alert()">.All 433 existing tests pass.