Harden cache runtime writes#89
Merged
Merged
Conversation
|
Test on Playground |
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Location, noSet-Cookie, and HTML content/body checks.hits,stale_hits,bypasses,lock_waits) so hot cache traffic no longer persistsperform_cache_statson every request.Validation
php -l src/Modules/Cache/PageCache.php && php -l src/Modules/Cache/StatsStore.php && php -l uninstall.phpgit diff --checksample.htmlandsample.meta.json; HTML response accepted; JSON and redirect responses rejected.1persisted a hit; large sample rate skipped repeated hit increments without creatingperform_cache_stats.Notes
composer check-cs -- src/Modules/Cache/PageCache.php src/Modules/Cache/StatsStore.php uninstall.phpis still blocked by pre-existing whole-file PHPCS violations in these files, mostly the repo's conflicting short-array rules and legacy formatting. I did not mass-format unrelated release code in this PR.Closes #82.
Closes #83.
Closes #84.
Closes #85.