Allow registry URL to be specified from a file#256
Open
kiberbunozes-ceo wants to merge 1 commit intoperiareon:mainfrom
Open
Allow registry URL to be specified from a file#256kiberbunozes-ceo wants to merge 1 commit intoperiareon:mainfrom
kiberbunozes-ceo wants to merge 1 commit intoperiareon:mainfrom
Conversation
Adds a new registry_url_file parameter to the helm_push rule, as an alternative to the registry_url parameter. This allows for the registry URL to be dynamically determined based on stamping / build flags / other means, with a generated file.
abrisco
requested changes
Apr 7, 2026
Collaborator
abrisco
left a comment
abrisco
left a comment
There was a problem hiding this comment.
Thanks! Can you add an integration test for this? Just a target showing the use of the new attribute?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new registry_url_file parameter to the helm_push rule, as an alternative to the registry_url parameter.
This allows for the registry URL to be dynamically determined based on stamping / build flags / other means, with a generated file.