Update angular test docs#3
Closed
soundproofboot wants to merge 4 commits into
Closed
Conversation
…#30483) Groups all of the Playwright dependencies together so we don't have the Docker one opened on its own like this: ionic-team#30472 Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
…30505) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@capacitor/core](https://capacitorjs.com) ([source](https://redirect.github.com/ionic-team/capacitor)) | [`7.3.0` -> `7.4.0`](https://renovatebot.com/diffs/npm/@capacitor%2fcore/7.3.0/7.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/capacitor (@&ionic-team#8203;capacitor/core)</summary> ### [`v7.4.0`](https://redirect.github.com/ionic-team/capacitor/blob/HEAD/CHANGELOG.md#740-2025-06-18) [Compare Source](https://redirect.github.com/ionic-team/capacitor/compare/7.3.0...7.4.0) ##### Features - **cli:** add spm-migration-assistant command ([#&ionic-team#8203;7963](https://redirect.github.com/ionic-team/capacitor/issues/7963)) ([ef42722](https://redirect.github.com/ionic-team/capacitor/commit/ef427225f63056b1731b3cd8941aea2311d3bc4d)) - **cli:** fail cap update on uninstalled cordova dependencies ([#&ionic-team#8203;8032](https://redirect.github.com/ionic-team/capacitor/issues/8032)) ([b393de8](https://redirect.github.com/ionic-team/capacitor/commit/b393de8bc9e68aff2cb70428a7c86c98367feade)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/ionic-team/ionic-framework). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> There are tests apps for Angular 16, 17, 18, and 19 only. Angular 20 has been released and should be included. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds a test app for Angular 20 ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
Owner
|
This looks like the right solution. Does it work on angular 19 and just not in 20, yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #2091 in docs repo
What is the current behavior?
Instructions to test ng-add schematic in Angular package are outdated.
What is the new behavior?
Added clarification to several steps and changed the npx command with the devkit library to use ng add instead, verified it is calling linked package if npm link is used corerctly.
Does this introduce a breaking change?
Other information
I did much much testing and exploring and the steps listed will work with @angular/cli@18.X as far as I can determine and will not work with @angular/cli @20.X but that seems like it is a separate issue. I believe the schematic itself would need to be changed to work with Angular 20 but the steps above should be the same.